Differential D6882

Remove 'process_timeout' from JournalClient's arguments
ClosedPublic
Actions

Authored by douardda on Jan 6 2022, 11:45 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDJNL0d115993e0f1: Remove 'process_timeout' from JournalClient's arguments

Summary

it was not used anywhere, so simplify the code a bit.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 6 2022, 11:45 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 6 2022, 11:45 AM

Build is green

Patch application report for D6882 (id=24958)

Rebasing onto 4e5e00988a...

Current branch diff-target is up to date.

Changes applied before test

commit 35bb07d74b2bc19353280770f825648c5d053bc4
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 4 17:25:02 2022 +0100

    Remove 'process_timeout' from JournalClient's arguments
    
    it was not used anywhere, so simplify the code a bit.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/188/ for more details.

Harbormaster completed remote builds in B25829: Diff 24958.Jan 6 2022, 11:49 AM

douardda requested review of this revision.Jan 6 2022, 11:49 AM

We spent so much time debugging this, it's a shame it's not used anymore :(

This revision is now accepted and ready to land.Jan 6 2022, 11:53 AM

vlorentz added inline comments.Jan 6 2022, 11:54 AM

swh/journal/client.py
226–229	this should be an exception IMO

douardda added inline comments.Jan 6 2022, 12:15 PM

swh/journal/client.py
226–229	you are probably right, will do

douardda added a child revision: D6884: Add support for the rdkafka 'stats_cb' config option in JournalClient.Jan 6 2022, 12:16 PM

make the warning an exception, as suggested by vlorentz

Build is green

Patch application report for D6882 (id=24963)

Rebasing onto 4e5e00988a...

Current branch diff-target is up to date.

Changes applied before test

commit 0d115993e0f1bd5e049ba07a1185ae29fcb6e654
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 4 17:25:02 2022 +0100

    Remove 'process_timeout' from JournalClient's arguments
    
    it was not used anywhere, so simplify the code a bit.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/190/ for more details.

Harbormaster completed remote builds in B25834: Diff 24963.Jan 6 2022, 12:38 PM

Closed by commit rDJNL0d115993e0f1: Remove 'process_timeout' from JournalClient's arguments (authored by douardda). · Explain WhyJan 6 2022, 2:25 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNL0d115993e0f1: Remove 'process_timeout' from JournalClient's arguments.