Page MenuHomeSoftware Heritage

Remove 'process_timeout' from JournalClient's arguments
ClosedPublic

Authored by douardda on Thu, Jan 6, 11:45 AM.

Details

Summary

it was not used anywhere, so simplify the code a bit.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6882 (id=24958)

Rebasing onto 4e5e00988a...

Current branch diff-target is up to date.
Changes applied before test
commit 35bb07d74b2bc19353280770f825648c5d053bc4
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 4 17:25:02 2022 +0100

    Remove 'process_timeout' from JournalClient's arguments
    
    it was not used anywhere, so simplify the code a bit.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/188/ for more details.

vlorentz added a subscriber: vlorentz.

We spent so much time debugging this, it's a shame it's not used anymore :(

This revision is now accepted and ready to land.Thu, Jan 6, 11:53 AM
swh/journal/client.py
226–229

this should be an exception IMO

swh/journal/client.py
226–229

you are probably right, will do

make the warning an exception, as suggested by vlorentz

Build is green

Patch application report for D6882 (id=24963)

Rebasing onto 4e5e00988a...

Current branch diff-target is up to date.
Changes applied before test
commit 0d115993e0f1bd5e049ba07a1185ae29fcb6e654
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 4 17:25:02 2022 +0100

    Remove 'process_timeout' from JournalClient's arguments
    
    it was not used anywhere, so simplify the code a bit.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/190/ for more details.