Page MenuHomeSoftware Heritage

requirements-test: Drop pre-commit
ClosedPublic

Authored by olasd on Dec 16 2021, 4:05 PM.

Details

Summary

pre-commit is needed externally, not for the actual swh.core tests

Test Plan

tox -e py3

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6858 (id=24852)

Rebasing onto 862e1e51a6...

Current branch diff-target is up to date.
Changes applied before test
commit a3ae85a6812feeca68dde4c55343ca3a0ef7922f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Dec 16 15:45:17 2021 +0100

    requirements-test: Drop pre-commit
    
    pre-commit is needed externally, not for the actual swh.core tests

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/259/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/259/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 16 2021, 4:06 PM
Harbormaster failed remote builds in B25711: Diff 24852!

btw, lgtm.

Just the broken build for side-tracked reason (mypy iirc).
So might be just a rebase on a latest master may fix it.

Build is green

Patch application report for D6858 (id=24997)

Rebasing onto 4ff374f2f7...

Current branch diff-target is up to date.
Changes applied before test
commit edec3bb7e9ef729acee27825547fb08acb8f71b5
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Dec 16 15:45:17 2021 +0100

    requirements-test: Drop pre-commit
    
    pre-commit is needed externally, not for the actual swh.core tests

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/260/ for more details.

olasd requested review of this revision.Fri, Jan 7, 3:19 PM
This revision is now accepted and ready to land.Fri, Jan 7, 3:50 PM

Build is green

Patch application report for D6858 (id=25208)

Rebasing onto de9b0c9fb4...

Current branch diff-target is up to date.
Changes applied before test
commit d374b6002955bf3591c84335b6bcc3521ff78061
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Dec 16 15:45:17 2021 +0100

    requirements-test: Drop pre-commit
    
    pre-commit is needed externally, not for the actual swh.core tests

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/263/ for more details.

This revision was automatically updated to reflect the committed changes.