pre-commit is needed externally, not for the actual swh.core tests
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDCOREd374b6002955: requirements-test: Drop pre-commit
tox -e py3
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D6858 (id=24852)
Rebasing onto 862e1e51a6...
Current branch diff-target is up to date.
Changes applied before test
commit a3ae85a6812feeca68dde4c55343ca3a0ef7922f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Thu Dec 16 15:45:17 2021 +0100
requirements-test: Drop pre-commit
pre-commit is needed externally, not for the actual swh.core testsLink to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/259/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/259/console
Comment Actions
btw, lgtm.
Just the broken build for side-tracked reason (mypy iirc).
So might be just a rebase on a latest master may fix it.
Comment Actions
Build is green
Patch application report for D6858 (id=24997)
Rebasing onto 4ff374f2f7...
Current branch diff-target is up to date.
Changes applied before test
commit edec3bb7e9ef729acee27825547fb08acb8f71b5
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Thu Dec 16 15:45:17 2021 +0100
requirements-test: Drop pre-commit
pre-commit is needed externally, not for the actual swh.core testsSee https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/260/ for more details.
Comment Actions
Build is green
Patch application report for D6858 (id=25208)
Rebasing onto de9b0c9fb4...
Current branch diff-target is up to date.
Changes applied before test
commit d374b6002955bf3591c84335b6bcc3521ff78061
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Thu Dec 16 15:45:17 2021 +0100
requirements-test: Drop pre-commit
pre-commit is needed externally, not for the actual swh.core testsSee https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/263/ for more details.