Differential D6832

bojimans: Fix postgresql version
ClosedPublic
Actions

Authored by ardumont on Dec 14 2021, 2:22 PM.

Details

Reviewers

vsellier

Group Reviewers

System administrators

Maniphest Tasks

T3802: Migrate bojimans (netbox) to bullseye

Commits

rSPSITEbdff3331756e: bojimans: Fix postgresql version

Summary

Otherwise, puppet refuses to apply [1].

[1]

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, No preferred version defined or automatically detected. (file: /etc/puppet/code/environments
/production/modules/postgresql/manifests/globals.pp, line: 228, column: 5) on node bojimans.internal.softwareheritage.org
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Related to T3802

Test Plan

octo-diff, but that shows no difference.

As i have yet again issues with vagrant, i did update puppet master and tried a noop run on bojimans.
And now the manifest applies (with this).

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 14 2021, 2:22 PM

Herald added a reviewer: System administrators. · View Herald TranscriptDec 14 2021, 2:22 PM

ardumont requested review of this revision.Dec 14 2021, 2:22 PM

Harbormaster completed remote builds in B25623: Diff 24770.Dec 14 2021, 2:22 PM

LGTM
not blocker, do we need the swh::postgresql::version indirection ?

This revision is now accepted and ready to land.Dec 14 2021, 2:26 PM

Isn't line 9 the default already?

(and could we consider upgrading this trivial database to a modern postgresql version now?)

Isn't line 9 the default already?

No, it's not apparently (if i drop this, the manifest won't apply)

(and could we consider upgrading this trivial database to a modern postgresql version now?)

That'd makes sense.
I noticed that it's something like a django inside (i recognized the django migration cli)

We should probably make an inventory of (postgres) dbs we got (with their current version) and start a migration plan again.

ardumont edited the test plan for this revision. (Show Details)Dec 14 2021, 2:31 PM

Closed by commit rSPSITEbdff3331756e: bojimans: Fix postgresql version (authored by ardumont). · Explain WhyDec 14 2021, 2:39 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPSITEbdff3331756e: bojimans: Fix postgresql version.

Isn't line 9 the default already?

No, it's not apparently (if i drop this, the manifest won't apply)

I've landed and deployed the fix nonetheless to unstuck the main task (which is
mostly done but for that somewhat unrelated error).
I'll check to make a clean up commit to converge towards that default.
If it's not too much a rabbithole, that should make it into a commit.

In D6832#177570, @ardumont wrote:

Isn't line 9 the default already?

No, it's not apparently (if i drop this, the manifest won't apply)

I've landed and deployed the fix nonetheless to unstuck the main task (which is
mostly done but for that somewhat unrelated error).
I'll check to make a clean up commit to converge towards that default.
If it's not too much a rabbithole, that should make it into a commit.

D6833