Differential D6829

Fix bug on the isochrone graph creation function
ClosedPublic
Actions

Authored by aeviso on Dec 13 2021, 4:36 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDPROVeb48f7960d06: Fix bug on the isochrone graph creation function

Summary

Isochrone frontiers with the same timestamp as the revision being
processes need to be invalidated to guarantee that the first
occurrence of a blob always ends up in the content-early-in-revision
relation. A new test is added that test the case of an incorrectly
processed revision leading to inconsistencies.

Diff Detail

Repository

rDPROV Provenance database

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 25621
Build 40065: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40064: arc lint + arc unit

Event Timeline

aeviso created this revision.Dec 13 2021, 4:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 13 2021, 4:36 PM

Build is green

Patch application report for D6829 (id=24755)

Rebasing onto 68ccaba838...

Current branch diff-target is up to date.

Changes applied before test

commit 29933f7bb18faac840c4482eac1cea4c543f64bb
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Dec 13 16:31:58 2021 +0100

    Fix bug on the isochrone graph creation function
    
    Isochrone frontiers with the same timestamp as the revision being
    processes need to be invalidated to guarantee that the first
    occurrence of a blob always ends up in the content-early-in-revision
    relation. A new test is added that test the case of an incorrectly
    processed revision leading to inconsistencies.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/543/ for more details.

Harbormaster completed remote builds in B25608: Diff 24755.Dec 13 2021, 4:42 PM

aeviso requested review of this revision.Dec 13 2021, 4:42 PM

olasd accepted this revision.Dec 13 2021, 5:07 PM

This revision is now accepted and ready to land.Dec 13 2021, 5:07 PM

improved associated test

Build is green

Patch application report for D6829 (id=24768)

Rebasing onto 68ccaba838...

Current branch diff-target is up to date.

Changes applied before test

commit eb48f7960d06f12788a5e16f84f03527fac8b504
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Dec 13 16:31:58 2021 +0100

    Fix bug on the isochrone graph creation function
    
    Isochrone frontiers with the same timestamp as the revision being
    processes need to be invalidated to guarantee that the first
    occurrence of a blob always ends up in the content-early-in-revision
    relation. A new test is added that test the case of an incorrectly
    processed revision leading to inconsistencies.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/544/ for more details.

Harbormaster completed remote builds in B25621: Diff 24768.Dec 14 2021, 2:17 PM

Closed by commit rDPROVeb48f7960d06: Fix bug on the isochrone graph creation function (authored by aeviso). · Explain WhyDec 14 2021, 2:22 PM

This revision was automatically updated to reflect the committed changes.

aeviso added a commit: rDPROVeb48f7960d06: Fix bug on the isochrone graph creation function.