Page MenuHomeSoftware Heritage
Differential D6820

tests/test_loader: Wrap empty svn repo creation in a fixture
ClosedPublic
Actions

Authored by anlambert on Dec 9 2021, 5:12 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDSVN0ae91422d8cb: tests/test_loader: Wrap empty svn repo creation in a fixture
Summary

Too much code duplication here.

Diff Detail

Event Timeline

anlambert created this revision.Dec 9 2021, 5:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2021, 5:12 PM
swh-public-ci added a comment.Dec 9 2021, 5:14 PM

Build is green

Patch application report for D6820 (id=24701)

Rebasing onto fffd2c45ec...

Current branch diff-target is up to date.
Changes applied before test
commit 0ae91422d8cb3639378de02eb832f1f983b57055
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 9 17:12:16 2021 +0100

    tests/test_loader: Wrap empty svn repo creation in a fixture

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/212/ for more details.

Harbormaster completed remote builds in B25554: Diff 24701.Dec 9 2021, 5:14 PM
anlambert requested review of this revision.Dec 9 2021, 5:14 PM
ardumont accepted this revision.Dec 9 2021, 9:20 PM
ardumont added a subscriber: ardumont.

totally, thx.

This revision is now accepted and ready to land.Dec 9 2021, 9:20 PM
Closed by commit rDLDSVN0ae91422d8cb: tests/test_loader: Wrap empty svn repo creation in a fixture (authored by anlambert). · Explain WhyDec 10 2021, 2:59 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDLDSVN0ae91422d8cb: tests/test_loader: Wrap empty svn repo creation in a fixture.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
loader/
svn/
tests/
88 lines99%
Loading...

Diff 24701

View Options

swh/loader/svn/tests/test_loader.py

Loading...
About · Developer information · Legal