Differential D6798

model: Deduplicate calls to hashlib.
ClosedPublic
Actions

Authored by vlorentz on Dec 8 2021, 5:21 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDMOD5eb65393af22: model: Deduplicate calls to hashlib.

Summary

It's just simpler this way

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 8 2021, 5:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 8 2021, 5:21 PM

vlorentz added a child revision: D6799: model: Add a check() method to model objects.Dec 8 2021, 5:21 PM

Build is green

Patch application report for D6798 (id=24647)

Could not rebase; Attempt merge onto c32290481c...

Updating c322904..5eb6539
Fast-forward
 swh/model/model.py            | 29 ++++++++++++++++-------------
 swh/model/tests/test_model.py |  1 +
 2 files changed, 17 insertions(+), 13 deletions(-)

Changes applied before test

commit 5eb65393af220b3e52f83f34bd27af9d0047cbf2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 16:20:38 2021 +0100

    model: Deduplicate calls to hashlib.
    
    It's just simpler this way

commit 2d0105b8413064db60aaa0802a45b0fad8b12d25
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 16:17:40 2021 +0100

    model: Add support for None to the type checker
    
    For the sake of completeness (a future commit may depend on it).

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/424/ for more details.

Harbormaster completed remote builds in B25505: Diff 24647.Dec 8 2021, 5:23 PM

vlorentz requested review of this revision.Dec 8 2021, 5:23 PM

Agreed.

This revision is now accepted and ready to land.Dec 8 2021, 5:25 PM

Closed by commit rDMOD5eb65393af22: model: Deduplicate calls to hashlib. (authored by vlorentz). · Explain WhyDec 9 2021, 11:26 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMOD5eb65393af22: model: Deduplicate calls to hashlib..

Revision Contents
Changeset List

Path

Size

swh/

model/

26 lines

Diff 24681

swh/model/model.py

Loading...