Page MenuHomeSoftware Heritage
Differential D678

Run property-based tests on RemoteStorage and in_memory.Storage.
ClosedPublic
Actions

Authored by vlorentz on Nov 20 2018, 11:51 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOCd1ce2445d247: Run property-based tests on RemoteStorage and in_memory.Storage.
R65:d1ce2445d247: Run property-based tests on RemoteStorage and in_memory.Storage.
rDSTOd1ce2445d247: Run property-based tests on RemoteStorage and in_memory.Storage.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 20 2018, 11:51 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2018, 11:51 AM
vlorentz updated this revision to Diff 2139.Nov 20 2018, 11:54 AM
  • Mark xfail instead of skip.
Harbormaster completed remote builds in B2459: Diff 2138.Nov 20 2018, 4:14 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 20 2018, 4:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/90/ for more details.

Harbormaster completed remote builds in B2460: Diff 2139.Nov 20 2018, 4:41 PM
swh-public-ci added a comment.Nov 20 2018, 4:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/95/ for more details.

ardumont accepted this revision.Nov 20 2018, 5:40 PM
ardumont added a subscriber: ardumont.

Thanks

swh/storage/tests/test_in_memory.py
47

What does this do?

It runs and if it fails, that displays the 'not implement yet' mention?

This revision is now accepted and ready to land.Nov 20 2018, 5:40 PM
vlorentz marked an inline comment as done.Nov 21 2018, 3:33 PM
vlorentz added inline comments.
swh/storage/tests/test_in_memory.py
47

It does not run, unless --runxfail is provided to pytest.

Closed by commit rDSTOd1ce2445d247: Run property-based tests on RemoteStorage and in_memory.Storage. (authored by vlorentz). · Explain WhyNov 21 2018, 3:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
tests/
17 lines
33 lines
12 lines

Diff 2158

View Options

swh/storage/tests/test_api_client.py

Loading...
View Options

swh/storage/tests/test_in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal