Differential D6768

test_cassandra: Fix failing tests since swh-model update
ClosedPublic
Actions

Authored by anlambert on Dec 7 2021, 1:38 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3776: cassandra tests are failing in the swh-environment build

Commits

rDSTO615fb99eb708: test_cassandra: Fix failing tests since swh-model update

Summary

Directory entries are now checked for name duplicates in swh-model
so we must ensure the CrashyEntry class is properly initialized.

Closes T3776

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 7 2021, 1:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 7 2021, 1:38 PM

Build is green

Patch application report for D6768 (id=24562)

Rebasing onto 850a7553b6...

Current branch diff-target is up to date.

Changes applied before test

commit 615fb99eb70818fa16e7f65e07c8db540a750115
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 7 13:36:28 2021 +0100

    test_cassandra: Fix failing tests since swh-model update
    
    Directory entries are now checked for name duplicates in swh-model
    so we must ensure the CrashyEntry class is properly initialized.
    
    Closes T3776

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1492/ for more details.

Harbormaster completed remote builds in B25434: Diff 24562.Dec 7 2021, 1:46 PM

anlambert requested review of this revision.Dec 7 2021, 1:46 PM

vlorentz accepted this revision.Dec 7 2021, 1:53 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/storage/tests/test_cassandra.py
543	FYI I think you should be able to do this, but no big deal

This revision is now accepted and ready to land.Dec 7 2021, 1:53 PM

anlambert added inline comments.Dec 7 2021, 1:56 PM

swh/storage/tests/test_cassandra.py

543

Computer says no:

self = <[TypeError("a bytes-like object is required, not '_Nothing'") raised in repr()] CrashyEntry object at 0x7f7aa159d5e0>

    def __init__(self):
>       super().__init__(**directory.entries[0].to_dict(), name=b"crash")
E       TypeError: swh.model.model.DirectoryEntry.__init__() got multiple values for keyword argument 'name'

swh/storage/tests/test_cassandra.py:543: TypeError

Closed by commit rDSTO615fb99eb708: test_cassandra: Fix failing tests since swh-model update (authored by anlambert). · Explain WhyDec 7 2021, 1:56 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTO615fb99eb708: test_cassandra: Fix failing tests since swh-model update.