Page MenuHomeSoftware Heritage
Differential D6752

test_hashutil: Port tests from unittest to pytest
ClosedPublic
Actions

Authored by anlambert on Dec 6 2021, 4:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDMOD243520daa827: test_hashutil: Port tests from unittest to pytest
Summary

One more legacy test file ported to pytest, still a couple of test files
to process in swh-model though.

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25393
Build 39695: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 39694: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 6 2021, 4:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2021, 4:07 PM
swh-public-ci added a comment.Dec 6 2021, 4:09 PM

Build has FAILED

Patch application report for D6752 (id=24515)

Rebasing onto 8d96dfedee...

First, rewinding head to replay your work on top of it...
Applying: test_hashutil: Port tests from unittest to pytest
Changes applied before test
commit a7d0cfae18fb1fb66be3fac6ef08bc0e8fdf0ee9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/404/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/404/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 6 2021, 4:09 PM
Harbormaster failed remote builds in B25389: Diff 24515!
anlambert updated this revision to Diff 24516.Dec 6 2021, 4:23 PM

Fix port of assertIs assertions

swh-public-ci added a comment.Dec 6 2021, 4:25 PM

Build has FAILED

Patch application report for D6752 (id=24516)

Rebasing onto 8d96dfedee...

First, rewinding head to replay your work on top of it...
Applying: test_hashutil: Port tests from unittest to pytest
Changes applied before test
commit 464cbc73f3efec27efa7bea428a4d9be14479d87
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/405/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/405/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 6 2021, 4:25 PM
Harbormaster failed remote builds in B25390: Diff 24516!
anlambert updated this revision to Diff 24519.Dec 6 2021, 5:24 PM

Fix failing tests due to mistakes in the porting process

swh-public-ci added a comment.Dec 6 2021, 5:26 PM

Build is green

Patch application report for D6752 (id=24519)

Rebasing onto 8d96dfedee...

First, rewinding head to replay your work on top of it...
Applying: test_hashutil: Port tests from unittest to pytest
Changes applied before test
commit f44d07eaf970fabb285225c6fd22d9eb9ea01e36
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/406/ for more details.

Harbormaster completed remote builds in B25393: Diff 24519.Dec 6 2021, 5:26 PM
anlambert requested review of this revision.Dec 6 2021, 5:26 PM
anlambert updated this revision to Diff 24522.Dec 6 2021, 5:42 PM

Rebase

anlambert added a child revision: D6755: hashutil: Add support for md5 sum.Dec 6 2021, 5:43 PM
swh-public-ci added a comment.Dec 6 2021, 5:43 PM

Build is green

Patch application report for D6752 (id=24522)

Rebasing onto 8d96dfedee...

Current branch diff-target is up to date.
Changes applied before test
commit 4a53fdcae885fdfb235c6b5df139e630ad088fc4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/407/ for more details.

Harbormaster completed remote builds in B25396: Diff 24522.Dec 6 2021, 5:44 PM
ardumont accepted this revision.Dec 6 2021, 5:48 PM
ardumont added a subscriber: ardumont.

"Blue blue, super blue!"

swh/model/tests/test_hashutil.py
185

nice addition

284

apparently, jenkins node does not have those deps, hence the coverage miss ;)

This revision is now accepted and ready to land.Dec 6 2021, 5:48 PM
anlambert added inline comments.Dec 6 2021, 7:06 PM
swh/model/tests/test_hashutil.py
284

If I recall correctly, that test was for Python versions (< 3.5) with no built-in support for blake2.

It makes me think that we could drop the associated code in hashutil and those tests as we are using Python 3.7 in production.

anlambert updated this revision to Diff 24524.Dec 6 2021, 7:28 PM

Add an autouse fixture to reset the blake2 cache

swh-public-ci added a comment.Dec 6 2021, 7:30 PM

Build is green

Patch application report for D6752 (id=24524)

Rebasing onto 8d96dfedee...

Current branch diff-target is up to date.
Changes applied before test
commit 243520daa82790ba05e8e88feea3065e905c03db
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/410/ for more details.

Harbormaster completed remote builds in B25398: Diff 24524.Dec 6 2021, 7:30 PM
Closed by commit rDMOD243520daa827: test_hashutil: Port tests from unittest to pytest (authored by anlambert). · Explain WhyDec 6 2021, 7:36 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDMOD243520daa827: test_hashutil: Port tests from unittest to pytest.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
model/
tests/
432 lines93%
Loading...

Diff 24519

View Options

swh/model/tests/test_hashutil.py

Loading...
About · Developer information · Legal