Differential D6744

debian: Update last_update for a package when required
ClosedPublic
Actions

Authored by anlambert on Dec 3 2021, 5:50 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2400: Ingest current and historical Ubuntu releases

Commits

rDLS15fa84cf7e35: debian: Update last_update for a package when required

Summary

A debian package can have sources coming from multiple suites
so we need to ensure to update the last_update field in the
ListedOrigin model if the current processed suite has a greater
modification time for its sources index.

Related to T2400

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25361
Build 39641: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39640: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 3 2021, 5:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 3 2021, 5:50 PM

Build is green

Patch application report for D6744 (id=24488)

Rebasing onto 93f17d4d9c...

Current branch diff-target is up to date.

Changes applied before test

commit 47b3e270c88d0f7bebfa19c7056a5ba0974a3d4e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Dec 3 17:46:07 2021 +0100

    debian: Update last_update for a package when required
    
    A debian package can have sources coming from multiple suites
    so we need to ensure to update the last_update field in the
    ListedOrigin model if the current processed suite has a greater
    modification time for its sources index.
    
    Related to T2400

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/429/ for more details.

Harbormaster completed remote builds in B25361: Diff 24488.Dec 3 2021, 5:53 PM

anlambert requested review of this revision.Dec 3 2021, 5:53 PM

lgtm

one suggestion inline.

swh/lister/debian/tests/test_lister.py
75–93	?

This revision is now accepted and ready to land.Dec 6 2021, 10:23 AM

Use enumerate in test

Build is green

Patch application report for D6744 (id=24496)

Rebasing onto 93f17d4d9c...

Current branch diff-target is up to date.

Changes applied before test

commit 15fa84cf7e35608a0a7a7bd4b0f9e5baeb90742d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Dec 3 17:46:07 2021 +0100

    debian: Update last_update for a package when required
    
    A debian package can have sources coming from multiple suites
    so we need to ensure to update the last_update field in the
    ListedOrigin model if the current processed suite has a greater
    modification time for its sources index.
    
    Related to T2400

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/430/ for more details.

Harbormaster completed remote builds in B25370: Diff 24496.Dec 6 2021, 10:46 AM

Closed by commit rDLS15fa84cf7e35: debian: Update last_update for a package when required (authored by anlambert). · Explain WhyDec 6 2021, 10:47 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLS15fa84cf7e35: debian: Update last_update for a package when required.

ardumont mentioned this in T2400: Ingest current and historical Ubuntu releases.Dec 8 2021, 3:31 PM