api: Fix documentation of the format used for git date fields
ClosedPublic
Actions

Authored by vlorentz on Dec 2 2021, 3:50 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS9502510d8092: api: Fix documentation of the format used for git date fields

Summary

They may contain negative UTC offsets, which is allowed by RFC3339,
but not by ISO8601.

See the last paragraph of https://en.wikipedia.org/wiki/ISO_8601#Time_offsets_from_UTC for details

I also removed (in UTC) because it's not true.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25329
Build 39590: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39589: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 2 2021, 3:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 2 2021, 3:50 PM

vlorentz edited the summary of this revision. (Show Details)Dec 2 2021, 3:52 PM

vlorentz added a child revision: D6731: api: Specify date formats more precisely.Dec 2 2021, 3:54 PM

vlorentz edited the summary of this revision. (Show Details)Dec 2 2021, 3:59 PM

Build is green

Patch application report for D6730 (id=24453)

Rebasing onto 284eec7e75...

Current branch diff-target is up to date.

Changes applied before test

commit 9502510d8092715c96894f7699a6c8c589865d74
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Dec 2 15:50:50 2021 +0100

    api: Fix documentation of the format used for git date fields
    
    They may contain negative UTC offsets, which is allowed by RFC3339,
    but not by ISO8601.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1259/ for more details.

Harbormaster completed remote builds in B25329: Diff 24453.Dec 2 2021, 4:08 PM

vlorentz requested review of this revision.Dec 2 2021, 4:08 PM

anlambert accepted this revision.Dec 2 2021, 4:19 PM

This revision is now accepted and ready to land.Dec 2 2021, 4:19 PM

Closed by commit rDWAPPS9502510d8092: api: Fix documentation of the format used for git date fields (authored by vlorentz). · Explain WhyDec 6 2021, 10:54 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS9502510d8092: api: Fix documentation of the format used for git date fields.