Differential D6716

Deduplicate origins in the GitHub lister
ClosedPublic
Actions

Authored by olasd on Dec 1 2021, 4:39 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLS5f567b3c3425: Deduplicate origins in the GitHub lister

Summary

In some circumstances, GitHub will return two separate repos with the
same html_url in the same page. This makes the lister fail with a
cardinality error.

Sentry report: https://sentry.softwareheritage.org/share/issue/642ff21b110740249c4b4bd1c0611be4/

Test Plan

a patched GitHub lister can continue on

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Dec 1 2021, 4:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 1 2021, 4:39 PM

Build is green

Patch application report for D6716 (id=24401)

Rebasing onto 8991c625ea...

Current branch diff-target is up to date.

Changes applied before test

commit 5f567b3c3425f7840f0639a766dabbdcb7688fb3
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Dec 1 16:00:14 2021 +0100

    Deduplicate origins in the GitHub lister
    
    In some circumstances, GitHub will return two separate repos with the
    same html_url in the same page. This makes the lister fail with a
    cardinality error.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/424/ for more details.

Harbormaster completed remote builds in B25278: Diff 24401.Dec 1 2021, 4:42 PM

olasd requested review of this revision.Dec 1 2021, 4:42 PM