Differential D6654

ra: Prevent erroneous removing of file state
ClosedPublic
Actions

Authored by anlambert on Nov 18 2021, 11:58 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN631a2b9d7f7e: ra: Prevent erroneous removing of file state

Summary

When recursively removing a directory content in a revision, ensure
to not remove state of file whose name has the same prefix as the
removed directory.

Related sentry issue

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25066
Build 39169: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39168: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 18 2021, 11:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 18 2021, 11:58 AM

anlambert edited the summary of this revision. (Show Details)Nov 18 2021, 11:59 AM

Build is green

Patch application report for D6654 (id=24184)

Rebasing onto fdf526ecea...

Current branch diff-target is up to date.

Changes applied before test

commit 631a2b9d7f7e1e9009cc2a4718e94128a625459a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 18 11:55:20 2021 +0100

    ra: Prevent erroneous removing of file state
    
    When recursively removing a directory content in a revision, ensure
    to not remove state of file whose name has the same prefix as the
    removed directory.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/193/ for more details.

Harbormaster completed remote builds in B25066: Diff 24184.Nov 18 2021, 12:00 PM

anlambert requested review of this revision.Nov 18 2021, 12:00 PM

ardumont accepted this revision.Nov 18 2021, 12:19 PM

This revision is now accepted and ready to land.Nov 18 2021, 12:19 PM

Closed by commit rDLDSVN631a2b9d7f7e: ra: Prevent erroneous removing of file state (authored by anlambert). · Explain WhyNov 18 2021, 12:40 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN631a2b9d7f7e: ra: Prevent erroneous removing of file state.