Differential D6642

git_bare: Send progress updates while cooking
ClosedPublic
Actions

Authored by vlorentz on Nov 16 2021, 2:00 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3727: Show the progress of vault tasks

Commits

rDVAUbd649ccb9793: git_bare: Send progress updates while cooking

Summary

It can be confusing to just have 'Processing...' in the UI for hours.
With this change, a new progress update should be sent every few minutes.

In the swh-web UI, it will show only 'Processing... %d objects processed'
in the main table, but 'Over %d remaining' will be shown when hovering
the progress bar (using a future diff to swh-web).
This does not show 'Processing... %d/%d' or a percentage, because the
number of remaining objects is not always known.

Resolves T3727

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 16 2021, 2:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 16 2021, 2:00 PM

Build is green

Patch application report for D6642 (id=24144)

Rebasing onto e2d3f274fb...

Current branch diff-target is up to date.

Changes applied before test

commit bd649ccb9793d1abaaad6455e7f25b48167a1c59
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 16 13:59:45 2021 +0100

    git_bare: Send progress updates while cooking
    
    It can be confusing to just have 'Processing...' in the UI for hours.
    With this change, a new progress update should be sent every few minutes.
    
    In the swh-web UI, it will show only 'Processing... %d objects processed'
    in the main table, but 'Over %d remaining' will be shown when hovering
    the progress bar.
    This does not show 'Processing... %d/%d' or a percentage, because the
    number of remaining objects is not always known.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/185/ for more details.

Harbormaster completed remote builds in B25024: Diff 24144.Nov 16 2021, 2:02 PM

vlorentz requested review of this revision.Nov 16 2021, 2:02 PM