Differential D6606

opam: Write package definitions to the extrinsic metadata storage
ClosedPublic
Actions

Authored by vlorentz on Nov 4 2021, 11:47 AM.

Details

Reviewers

aleo

Maniphest Tasks

T3636: Make the opam loader write extrinsic metadata

Commits

rDLDBASEaeffe01a2b39: opam: Write package definitions to the extrinsic metadata storage

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 4 2021, 11:47 AM

Build is green

Patch application report for D6606 (id=23998)

Could not rebase; Attempt merge onto 5063082e7d...

Updating 5063082..0d04182
Fast-forward
 docs/package-loader-tutorial.rst           | 25 ++++++++++
 swh/loader/package/opam/loader.py          | 41 +++++++++++++---
 swh/loader/package/opam/tests/test_opam.py | 76 +++++++++++++++++++++++++++++-
 3 files changed, 133 insertions(+), 9 deletions(-)

Changes applied before test

commit 0d04182ecce3ab34c2ed648bbafa83ab5204e0b0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 4 11:45:36 2021 +0100

    opam: Write package definitions to the extrinsic metadata storage

commit 18bbbae719fc9d165d5b543e54d449f5befc083a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 4 11:43:53 2021 +0100

    Add missing documentation for `get_metadata_authority`.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/593/ for more details.

Harbormaster completed remote builds in B24871: Diff 23998.Nov 4 2021, 11:49 AM

vlorentz requested review of this revision.Nov 4 2021, 11:49 AM

actually fetch the metadata from opam, instead of just the first line...

Build is green

Patch application report for D6606 (id=24012)

Could not rebase; Attempt merge onto 5063082e7d...

Updating 5063082..aeffe01
Fast-forward
 docs/package-loader-tutorial.rst           |  25 ++++++
 swh/loader/package/opam/loader.py          |  67 +++++++++++-----
 swh/loader/package/opam/tests/test_opam.py | 119 ++++++++++++++++++++++++++++-
 3 files changed, 188 insertions(+), 23 deletions(-)

Changes applied before test

commit aeffe01a2b3918262e4bd715ea52c7d7da27807c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 4 11:45:36 2021 +0100

    opam: Write package definitions to the extrinsic metadata storage

commit 18bbbae719fc9d165d5b543e54d449f5befc083a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 4 11:43:53 2021 +0100

    Add missing documentation for `get_metadata_authority`.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/599/ for more details.

Harbormaster completed remote builds in B24885: Diff 24012.Nov 4 2021, 6:58 PM

LGTM now. :)

This revision is now accepted and ready to land.Nov 4 2021, 7:53 PM

vlorentz added a child revision: D6616: Make package loaders write releases instead of revisions.Nov 5 2021, 1:27 PM

vlorentz added a task: T3636: Make the opam loader write extrinsic metadata.Nov 8 2021, 11:58 AM

Closed by commit rDLDBASEaeffe01a2b39: opam: Write package definitions to the extrinsic metadata storage (authored by vlorentz). · Explain WhyNov 10 2021, 2:21 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASEaeffe01a2b39: opam: Write package definitions to the extrinsic metadata storage.