Page MenuHomeSoftware Heritage

Allow release authors to be None even if the date is not None
AbandonedPublic

Authored by vlorentz on Tue, Nov 9, 3:52 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

I don't see any reason for this restriction, release dates are usually
available info, while authors are not defined.

Package loaders worked around this restriction by setting
the empty string as author, anyway...

This matches the change in swh-model @ D6627

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24956
Build 38999: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38998: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6628 (id=24081)

Rebasing onto 0262f1c191...

Current branch diff-target is up to date.
Changes applied before test
commit 137ec8880c78d2b8ff848dca05ac5522205990f1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 9 15:51:28 2021 +0100

    Allow release authors to be None even if the date is not None
    
    I don't see any reason for this restriction, release dates are usually
    available info, while authors are not defined.
    
    Package loaders worked around this restriction by setting
    the empty string as author, anyway...
    
    This matches the change in swh-model @ 39bcfc05061f6312323a3698559a5b064947a031

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1485/ for more details.

abandonning this, as there isn't a good way to serialize manifests with a date but no author