Differential D6599

Revert "deposit: Remove 'parent' deposit"
ClosedPublic
Actions

Authored by vlorentz on Nov 3 2021, 3:56 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDBASE5063082e7dc1: Revert "deposit: Remove 'parent' deposit"

Summary

This reverts commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6.

That commit was a first step toward making loaders write releases
instead of revisions.

Unfortunately, we will still write revisions for a non-negligeable time,
so I prefer to defer the removal of parent deposit revisions to the
moment we actually make that switch, so we don't end up with inconsistent
revisions.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24858
Build 38824: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38823: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 3 2021, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 3 2021, 3:56 PM

better commit msg

Build is green

Patch application report for D6599 (id=23983)

Rebasing onto 9f8827935d...

Current branch diff-target is up to date.

Changes applied before test

commit 645ed666d87e850e4fd6c057d1b7488c0e31524c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 15:54:05 2021 +0100

    Revert "deposit: Remove 'parent' deposit"
    
    This reverts commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/588/ for more details.

Harbormaster completed remote builds in B24858: Diff 23983.Nov 3 2021, 3:58 PM

Build is green

Patch application report for D6599 (id=23984)

Rebasing onto 9f8827935d...

Current branch diff-target is up to date.

Changes applied before test

commit 5063082e7dc176939e2f952b83f10cf0b1f0aabc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 15:54:05 2021 +0100

    Revert "deposit: Remove 'parent' deposit"
    
    This reverts commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6.
    
    That commit was a first step toward making loaders write releases
    instead of revisions.
    
    Unfortunately, we will still write revisions for a non-negligeable time,
    so I prefer to defer the removal of parent deposit revisions to the
    moment we actually make that switch, so we don't end up with inconsistent
    revisions.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/589/ for more details.

Harbormaster completed remote builds in B24859: Diff 23984.Nov 3 2021, 3:59 PM

vlorentz requested review of this revision.Nov 3 2021, 3:59 PM

anlambert accepted this revision.Nov 3 2021, 4:01 PM

This revision is now accepted and ready to land.Nov 3 2021, 4:01 PM

Closed by commit rDLDBASE5063082e7dc1: Revert "deposit: Remove 'parent' deposit" (authored by vlorentz). · Explain WhyNov 3 2021, 4:04 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE5063082e7dc1: Revert "deposit: Remove 'parent' deposit".

vlorentz added a reverting change: D6600: deposit: Remove 'parent' deposit.Nov 3 2021, 4:13 PM