Page MenuHomeSoftware Heritage
Differential D659

Add intrinsic metadata indexers to puppet.
ClosedPublic
Actions

Authored by vlorentz on Nov 15 2018, 3:34 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rSPSITE7ed8a77a2317: empty test commit.
rSPSITE01b727e7e1c2: empty test commit.
rSPSITE3bc4b9bebd36: Add intrinsic metadata indexers to puppet.

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 15 2018, 3:34 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 15 2018, 3:34 PM
Harbormaster completed remote builds in B2399: Diff 2071.Nov 15 2018, 3:34 PM
vlorentz added a reviewer: ardumont.Nov 15 2018, 3:35 PM
ardumont requested changes to this revision.Nov 15 2018, 3:40 PM
ardumont added inline comments.
data/defaults.yaml
1957

Thanks for the clean up.

1982

That's probably not swh_indexer::mimetype that you want here.
swh_indexer::revision_metadata more like ;)

This revision now requires changes to proceed.Nov 15 2018, 3:40 PM
vlorentz updated this revision to Diff 2072.Nov 15 2018, 3:53 PM
  • Fix name.
Harbormaster completed remote builds in B2400: Diff 2072.Nov 15 2018, 3:53 PM
vlorentz marked 2 inline comments as done.Nov 15 2018, 3:53 PM
vlorentz added inline comments.
data/defaults.yaml
1982

Oops, broken regexp

vlorentz mentioned this in D661: Add swh_indexer_origin_head..Nov 15 2018, 4:24 PM
vlorentz added a parent revision: D661: Add swh_indexer_origin_head..Nov 15 2018, 4:24 PM
vlorentz mentioned this in D662: Don't share the same config across different indexers..Nov 15 2018, 4:25 PM
vlorentz added a parent revision: D662: Don't share the same config across different indexers..Nov 15 2018, 4:26 PM
vlorentz mentioned this in rDCIDX429ac26da3cc: Don't share the same config across different indexers..Nov 16 2018, 10:02 AM
vlorentz mentioned this in rDCIDX407a88f2ca35: Add swh_indexer_origin_head..
ardumont accepted this revision.Nov 16 2018, 10:07 AM

Sounds good.

It's probably time to open a task to refactor those some more ;)

site-modules/profile/manifests/swh/deploy/worker/swh_indexer_origin_intrinsic_metadata.pp
1

swh_origin_intrinsic_metadata

This revision is now accepted and ready to land.Nov 16 2018, 10:07 AM
vlorentz updated this revision to Diff 2083.Nov 16 2018, 10:15 AM
vlorentz marked an inline comment as done.
  • Fix comment.
Harbormaster completed remote builds in B2412: Diff 2083.Nov 16 2018, 10:15 AM
Closed by commit rSPSITE3bc4b9bebd36: Add intrinsic metadata indexers to puppet. (authored by vlorentz). · Explain WhyNov 16 2018, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
data/
28 lines
site-modules/
profile/
manifests/
swh/
deploy/
worker/
38 lines
38 lines
39 lines

Diff 2084

View Options

data/defaults.yaml

Loading...
View Options

site-modules/profile/manifests/swh/deploy/worker/swh_indexer_origin_head.pp

Loading...
View Options

site-modules/profile/manifests/swh/deploy/worker/swh_indexer_origin_intrinsic_metadata.pp

Loading...
View Options

site-modules/profile/manifests/swh/deploy/worker/swh_indexer_revision_metadata.pp

Loading...
About · Developer information · Legal