Page MenuHomeSoftware Heritage

Add a simple read-only HTTP backend
ClosedPublic

Authored by douardda on Oct 20 2021, 4:51 PM.

Details

Summary

suitable for example to use for a S3 backend.

Diff Detail

Event Timeline

Build is green

Patch application report for D6521 (id=23703)

Rebasing onto 6269067ca7...

Current branch diff-target is up to date.
Changes applied before test
commit b84674bb6ad757e04bd5efd6573dbb8427522da8
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/52/ for more details.

remove mistakenly commited mypy.ini file

Build is green

Patch application report for D6521 (id=23704)

Rebasing onto 6269067ca7...

Current branch diff-target is up to date.
Changes applied before test
commit 6eb9b7637c08582f2ba11e08a5254909fb00721b
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/53/ for more details.

Build is green

Patch application report for D6521 (id=23705)

Rebasing onto 6269067ca7...

Current branch diff-target is up to date.
Changes applied before test
commit 31606f2354a3aaff945ed70654b6859963fcc39f
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/54/ for more details.

document the build_objstorage() test helper function

Build is green

Patch application report for D6521 (id=23707)

Rebasing onto 6269067ca7...

Current branch diff-target is up to date.
Changes applied before test
commit 201b9ecc36d20b6ac7f0413dd922d9d6a2204ce8
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/55/ for more details.

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/objstorage/backends/http.py
44

why would it?

51–61

could you add messages? Just "HTTPReadOnlyObjStorage does not implement xxx" would be fine. (the traceback isn't always preserved when the error goes through a serialization layer)

swh/objstorage/tests/test_objstorage_http.py
39

not covered?

This revision now requires changes to proceed.Oct 21 2021, 11:46 AM
swh/objstorage/backends/http.py
44

blind copy/paste... will remove

51–61

good thinking, will do

swh/objstorage/tests/test_objstorage_http.py
39

indeed, it's covered for the HEAD query but not the GET. Will fix

Use ReadOnlyObjStorage and NonIterableObjStorage instead of NotImplementedError

and add a few tests.

Build has FAILED

Patch application report for D6521 (id=23719)

Rebasing onto 6269067ca7...

Current branch diff-target is up to date.
Changes applied before test
commit 5b94c973119e1df221329837e0f3b9bef7961f09
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/56/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/56/console

Build is green

Patch application report for D6521 (id=23719)

Rebasing onto 6269067ca7...

Current branch diff-target is up to date.
Changes applied before test
commit 5b94c973119e1df221329837e0f3b9bef7961f09
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/57/ for more details.

Build is green

Patch application report for D6521 (id=23734)

Rebasing onto bcbbfd4669...

Current branch diff-target is up to date.
Changes applied before test
commit 8ed5f4ebc91524639906d9866f7828660ccd9b06
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Oct 4 09:48:02 2021 +0200

    Add a simple read-only HTTP backend
    
    suitable for example to use for a S3 backend.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/63/ for more details.

This revision is now accepted and ready to land.Oct 21 2021, 2:18 PM
This revision was automatically updated to reflect the committed changes.