Differential D6515

Drop deprecated listener module
ClosedPublic
Actions

Authored by ardumont on Oct 20 2021, 10:45 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3667: Orchestrate origins scheduling according to scheduler metrics feedback

Commits

rDSCH5b531964a458: Drop deprecated listener module

Summary

It's been deprecated for enough time. The pika_listener has been running in its place.

Related to T3667

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 24557
Build 38318: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38317: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 20 2021, 10:45 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 20 2021, 10:45 AM

Build has FAILED

Patch application report for D6515 (id=23654)

Could not rebase; Attempt merge onto 3aed6887fc...

Updating 3aed688..d9c6829
Fast-forward
 requirements-test.txt                         |   1 +
 swh/scheduler/backend.py                      |   2 +-
 swh/scheduler/celery_backend/listener.py      | 220 --------------------------
 swh/scheduler/celery_backend/pika_listener.py |   7 +-
 swh/scheduler/celery_backend/runner.py        |  10 ++
 5 files changed, 18 insertions(+), 222 deletions(-)
 delete mode 100644 swh/scheduler/celery_backend/listener.py

Changes applied before test

commit d9c68297bb6eb937b55df0277dcaa2d64440d30a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 10:44:34 2021 +0200

    Drop deprecated listener module
    
    It's been deprecated for enough time.
    
    Related to T3667

commit f14ee2c827d54b0341d0672108b1900e498dc76d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 10:42:34 2021 +0200

    Add docstring to runner and listener modules
    
    Related to T3667

commit 6e0a4b3088fca858b9914c41ecd0b8f6aaca853d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 10:41:38 2021 +0200

    backend: Add type ignore
    
    We cannot do much about that type issue since it's a dependency definition.

commit f15c51091439f499c5ab1c2cb75e3d058cb64341
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:36:27 2021 +0200

    scheduler: Deprecate unused main celery runner

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/460/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/460/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2021, 10:46 AM

Harbormaster failed remote builds in B24544: Diff 23654!

Fix

Build is green

Patch application report for D6515 (id=23659)

Could not rebase; Attempt merge onto 3aed6887fc...

Updating 3aed688..7ced45e
Fast-forward
 requirements-test.txt                         |   1 +
 swh/scheduler/celery_backend/listener.py      | 220 --------------------------
 swh/scheduler/celery_backend/pika_listener.py |   7 +-
 swh/scheduler/celery_backend/runner.py        |  10 ++
 4 files changed, 17 insertions(+), 221 deletions(-)
 delete mode 100644 swh/scheduler/celery_backend/listener.py

Changes applied before test

commit 7ced45e7442551ffcd18a0718c3f35df1db8e1f1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 10:44:34 2021 +0200

    Drop deprecated listener module
    
    It's been deprecated for enough time.
    
    Related to T3667

commit 3d2d853cbce42fb632a95661245b1eb6cbdf515d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 10:42:34 2021 +0200

    Add docstring to runner and listener modules
    
    Related to T3667

commit f15c51091439f499c5ab1c2cb75e3d058cb64341
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:36:27 2021 +0200

    scheduler: Deprecate unused main celery runner

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/462/ for more details.

Harbormaster completed remote builds in B24549: Diff 23659.Oct 20 2021, 10:52 AM

ardumont requested review of this revision.Oct 20 2021, 10:52 AM

anlambert accepted this revision.Oct 20 2021, 10:56 AM

This revision is now accepted and ready to land.Oct 20 2021, 10:56 AM

Rebase

Build is green

Patch application report for D6515 (id=23669)

Rebasing onto f15c510914...

Current branch diff-target is up to date.

Changes applied before test

commit 5b531964a45843eb4310c1fadd60958fba0b6041
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 10:44:34 2021 +0200

    Drop deprecated listener module
    
    It's been deprecated for enough time.
    
    Related to T3667

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/463/ for more details.

Harbormaster completed remote builds in B24557: Diff 23669.Oct 20 2021, 11:06 AM

Closed by commit rDSCH5b531964a458: Drop deprecated listener module (authored by ardumont). · Explain WhyOct 20 2021, 11:11 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH5b531964a458: Drop deprecated listener module.