Differential D6472

Add a script for a 'monthly roadmap report' bot email
ClosedPublic
Actions

Authored by vlorentz on Oct 14 2021, 11:24 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators
Reviewers

Commits

rSPSITE5d186a2a0cdb: Add a script for a 'monthly roadmap report' bot email

Test Plan

Not tested :|

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz requested review of this revision.Oct 14 2021, 11:24 AM

vlorentz created this revision.

Harbormaster completed remote builds in B24422: Diff 23511.Oct 14 2021, 11:24 AM

vlorentz added reviewers: System administrators, Reviewers.Oct 14 2021, 11:25 AM

vlorentz added 1 blocking reviewer(s): System administrators.

Good idea.

Do we have the same for the weekly report already?

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	You can make it parametrized on the year as well. That way, no need to update it next year.

Do we have the same for the weekly report already?

yes, we do, same link as the comment [1]

[1] https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/site-modules/role/manifests/swh_sysadmin.pp$28

site-modules/profile/manifests/monthly_report_bot.pp
22	That profile must be installed in the role somewhere otherwise, that won't do anything. I'd say probably pergamon again [1] [1] https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/site-modules/role/manifests/swh_sysadmin.pp$28

ardumont added inline comments.Oct 14 2021, 1:23 PM

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	actual suggestion with a diff ;)

I'm fine with the idea.
I've suggested a couple of fix, one actually be blocking.

olasd added a subscriber: olasd.Oct 14 2021, 2:13 PM

olasd added inline comments.

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	The 2022 roadmap won't exist on the first month of 2022, so I guess it's fine to keep the year hardcoded.

ardumont added inline comments.Oct 14 2021, 2:15 PM

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	Unless someone actually installs an empty template very early in the year. Either way that's work so fine with either road we are taking.

ardumont added inline comments.Oct 14 2021, 2:35 PM

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	Either way that's work so fine with either road we are taking. Either way is fine with me*

vlorentz added inline comments.Oct 15 2021, 11:22 AM

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	once we have at least two roadmaps, we will probably add an index of roadmaps in the doc, and the email can link to that.

install on pergamon

Harbormaster completed remote builds in B24457: Diff 23552.Oct 15 2021, 11:23 AM

Thanks.

site-modules/profile/files/weekly_report_bot/monthly-report-bot
18	yes, good idea.

This revision is now accepted and ready to land.Oct 18 2021, 11:57 AM

rebase

Harbormaster completed remote builds in B24487: Diff 23591.Oct 18 2021, 12:22 PM

Closed by commit rSPSITE5d186a2a0cdb: Add a script for a 'monthly roadmap report' bot email (authored by vlorentz). · Explain WhyOct 18 2021, 12:22 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rSPSITE5d186a2a0cdb: Add a script for a 'monthly roadmap report' bot email.

Revision Contents
Changeset List

Path

Size

data/

common/

6 lines

site-modules/

profile/

files/

weekly_report_bot/

monthly-report-bot

23 lines

manifests/

monthly_report_bot.pp

22 lines

role/

manifests/

swh_sysadmin.pp

1 line

Diff 23592

data/common/common.yaml

Loading...

site-modules/profile/files/weekly_report_bot/monthly-report-bot

Loading...

site-modules/profile/manifests/monthly_report_bot.pp

Loading...

site-modules/role/manifests/swh_sysadmin.pp

Loading...