Page MenuHomeSoftware Heritage

make the black code formatter skip the pserver scramble shift table
ClosedPublic

Authored by stsp on Fri, Oct 1, 2:56 PM.

Details

Summary

This table becomes unreadable after the black formatter inserts
a newline between all the table entries.

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6389 (id=23238)

Could not rebase; Attempt merge onto 62b0f560ef...

Updating 62b0f56..ea46945
Fast-forward
 swh/loader/cvs/cvsclient.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Changes applied before test
commit ea469457eda20309fbef67e2970063d6b3cf500b
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Oct 1 14:51:03 2021 +0200

    make the black code formatter skip the pserver scramble shift table
    
    This table becomes unreadable after the black formatter inserts
    a newline between all the table entries.

commit 2b41f5205f62d0778cff55c326f256977d162b28
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Oct 1 14:43:53 2021 +0200

    fix pserver authentication error
    
    Testing against cvs.savannah.gnu.org revealed that the CVS module
    name should not be included in the authentication request.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/30/ for more details.

stsp requested review of this revision.Fri, Oct 1, 2:58 PM

Build is green

Patch application report for D6389 (id=23242)

Rebasing onto 2b41f5205f...

Current branch diff-target is up to date.
Changes applied before test
commit ea469457eda20309fbef67e2970063d6b3cf500b
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Oct 1 14:51:03 2021 +0200

    make the black code formatter skip the pserver scramble shift table
    
    This table becomes unreadable after the black formatter inserts
    a newline between all the table entries.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/31/ for more details.

This revision is now accepted and ready to land.Fri, Oct 1, 4:22 PM