Differential D6383

fix TypeError due to wrong LoadCvsRepository task description
ClosedPublic
Actions

Authored by stsp on Oct 1 2021, 11:47 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDCVS62b0f560ef7e: fix TypeError due to wrong LoadCvsRepository task description

Summary

The CVS loader's URL argument is mandatory so it should not be
marked as optional.

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24139
Build 37670: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37669: arc lint + arc unit

Event Timeline

stsp created this revision.Oct 1 2021, 11:47 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 1 2021, 11:47 AM

Build is green

Patch application report for D6383 (id=23222)

Rebasing onto a7eaeb89f4...

Current branch diff-target is up to date.

Changes applied before test

commit 62b0f560ef7e017a6649d01d92ce70736630821f
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Oct 1 11:46:36 2021 +0200

    fix TypeError due to wrong LoadCvsRepository task description
    
    The CVS loader's URL argument is mandatory so it should not be
    marked as optional.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/28/ for more details.

Harbormaster completed remote builds in B24139: Diff 23222.Oct 1 2021, 11:49 AM

stsp requested review of this revision.Oct 1 2021, 11:49 AM

vlorentz accepted this revision.Oct 1 2021, 11:49 AM

This revision is now accepted and ready to land.Oct 1 2021, 11:49 AM

Closed by commit rDLDCVS62b0f560ef7e: fix TypeError due to wrong LoadCvsRepository task description (authored by stsp). · Explain WhyOct 1 2021, 11:51 AM

This revision was automatically updated to reflect the committed changes.

stsp added a commit: rDLDCVS62b0f560ef7e: fix TypeError due to wrong LoadCvsRepository task description.