Page MenuHomeSoftware Heritage

admin/origin_save: Parse optional note from rejection POST request body
ClosedPublic

Authored by anlambert on Sep 20 2021, 5:48 PM.

Details

Summary

Optional rejection note for a save request will be send in POST request
body of the "admin-origin-save-request-reject" django admin view.

Related to T3256

Depends on D6309

Diff Detail

Repository
rDWAPPS Web applications
Branch
admin-origin-save-reject-with-note
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24238
Build 37832: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 37831: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6311 (id=22903)

Could not rebase; Attempt merge onto 6700905387...

Updating 67009053..5655524d
Fast-forward
 swh/web/admin/origin_save.py                       |  4 +++
 swh/web/api/views/origin_save.py                   |  2 ++
 .../migrations/0012_saveoriginrequest_note.py      | 21 +++++++++++++++
 swh/web/common/models.py                           |  2 ++
 swh/web/common/typing.py                           |  2 ++
 swh/web/tests/admin/test_origin_save.py            | 31 ++++++++++++++++++++++
 swh/web/tests/common/test_django_command.py        |  1 +
 swh/web/tests/common/test_origin_save.py           |  3 +++
 swh/web/tests/test_migrations.py                   | 11 ++++----
 9 files changed, 72 insertions(+), 5 deletions(-)
 create mode 100644 swh/web/common/migrations/0012_saveoriginrequest_note.py
Changes applied before test
commit 5655524daf96507fb204b79c6e7e6e7541797184
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 20 17:44:46 2021 +0200

    admin/origin_save: Parse optional note from rejection POST request body
    
    Optional rejection note for a save request will be send in POST request
    body of the "admin-origin-save-request-reject" django admin view.
    
    Related to T3256

commit 7876a42ec4abfb026fd1497827642ab7343b9691
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 11:44:50 2021 +0200

    common/models: Add note text field to SaveOriginRequest model
    
    It will enable to store a swh-web admin redacted note related to
    the save request, for instance the reason of rejection or explain
    why a submitted save request failed.
    
    Related to T3256

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1110/ for more details.

This revision is now accepted and ready to land.Sep 20 2021, 6:09 PM

Build has FAILED

Patch application report for D6311 (id=23324)

Could not rebase; Attempt merge onto f2765a820a...

Updating f2765a82..a47b5017
Fast-forward
 swh/web/admin/origin_save.py                       |  4 +++
 swh/web/api/views/origin_save.py                   |  2 ++
 .../migrations/0012_saveoriginrequest_note.py      | 21 +++++++++++++++
 swh/web/common/models.py                           |  2 ++
 swh/web/common/typing.py                           |  2 ++
 swh/web/tests/admin/test_origin_save.py            | 31 ++++++++++++++++++++++
 swh/web/tests/common/test_django_command.py        |  1 +
 swh/web/tests/common/test_origin_save.py           |  3 +++
 swh/web/tests/test_migrations.py                   | 11 ++++----
 9 files changed, 72 insertions(+), 5 deletions(-)
 create mode 100644 swh/web/common/migrations/0012_saveoriginrequest_note.py
Changes applied before test
commit a47b5017c25335e7f9e1bee5dc1b3d6adeedc672
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 20 17:44:46 2021 +0200

    admin/origin_save: Parse optional note from rejection POST request body
    
    Optional rejection note for a save request will be send in POST request
    body of the "admin-origin-save-request-reject" django admin view.
    
    Related to T3256

commit 86601bceb57bc0f783b9fe27180fcdb691f926bb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 11:44:50 2021 +0200

    common/models: Add note text field to SaveOriginRequest model
    
    It will enable to store a swh-web admin redacted note related to
    the save request, for instance the reason of rejection or explain
    why a submitted save request failed.
    
    Related to T3256

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1139/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1139/console

Build is green

Patch application report for D6311 (id=23325)

Could not rebase; Attempt merge onto f2765a820a...

Updating f2765a82..84e550f6
Fast-forward
 swh/web/admin/origin_save.py                       |  4 +++
 swh/web/api/views/origin_save.py                   |  2 ++
 .../migrations/0012_saveoriginrequest_note.py      | 21 +++++++++++++++
 swh/web/common/models.py                           |  2 ++
 swh/web/common/typing.py                           |  2 ++
 swh/web/tests/admin/test_origin_save.py            | 31 ++++++++++++++++++++++
 swh/web/tests/common/test_django_command.py        |  1 +
 swh/web/tests/common/test_origin_save.py           |  3 +++
 swh/web/tests/test_migrations.py                   | 11 ++++----
 9 files changed, 72 insertions(+), 5 deletions(-)
 create mode 100644 swh/web/common/migrations/0012_saveoriginrequest_note.py
Changes applied before test
commit 84e550f6bf688636e4821cfe37ae983a23121939
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 20 17:44:46 2021 +0200

    admin/origin_save: Parse optional note from rejection POST request body
    
    Optional rejection note for a save request will be send in POST request
    body of the "admin-origin-save-request-reject" django admin view.
    
    Related to T3256

commit 86601bceb57bc0f783b9fe27180fcdb691f926bb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 11:44:50 2021 +0200

    common/models: Add note text field to SaveOriginRequest model
    
    It will enable to store a swh-web admin redacted note related to
    the save request, for instance the reason of rejection or explain
    why a submitted save request failed.
    
    Related to T3256

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1140/ for more details.