Differential D6296

Ignore generated .so files
ClosedPublic
Actions

Authored by vlorentz on Sep 17 2021, 4:36 PM.

Details

Reviewers

stsp

Commits

rDLDCVS6d8a74f44f47: Ignore generated .so files

Summary

They are in this location when installing in development mode.

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23802
Build 37110: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37109: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 17 2021, 4:36 PM

Build is green

Patch application report for D6296 (id=22873)

Could not rebase; Attempt merge onto dd8a625ca0...

Auto-merging swh/loader/cvs/loader.py
Merge made by the 'recursive' strategy.
 .gitignore                          |  1 +
 swh/loader/cvs/loader.py            | 65 ++++++++++++++++++++-----------------
 swh/loader/cvs/tests/test_loader.py |  3 ++
 3 files changed, 40 insertions(+), 29 deletions(-)

Changes applied before test

commit 555a66aed05b5be244f92f255da433e678d27c5d
Merge: dd8a625 051dec1
Author: Jenkins user <jenkins@localhost>
Date:   Fri Sep 17 14:36:47 2021 +0000

    Merge branch 'diff-target' into HEAD

commit 051dec1fe0c0252cb569ecf763b49210280cfe7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:36:07 2021 +0200

    Ignore generated .so files
    
    They are in this location when installing in development mode.

commit af3755766012b58ddf5713fb2e0504033c9de903
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:34:37 2021 +0200

    Use lazy substitution for logging + fix error messages
    
    eg. self.log.exception already include the exception (and its traceback),
    so it does not need to be part of the message.

commit b7e97029636648ddb53ad7bed8623e97a546e445
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:28:52 2021 +0200

    load_status should not be 'uneventful' if the snapshot changed
    
    Even if the revision was already loaded; it might have been for
    a different origin.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/17/ for more details.

Harbormaster completed remote builds in B23802: Diff 22873.Sep 17 2021, 4:38 PM

vlorentz requested review of this revision.Sep 17 2021, 4:38 PM

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Sep 21 2021, 5:58 PM

This revision was landed with ongoing or failed builds.

Closed by commit rDLDCVS6d8a74f44f47: Ignore generated .so files (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDCVS6d8a74f44f47: Ignore generated .so files.

Build is green

Patch application report for D6296 (id=22939)

Could not rebase; Attempt merge onto dd8a625ca0...

Updating dd8a625..6d8a74f
Fast-forward
 .gitignore                          |  1 +
 swh/loader/cvs/loader.py            | 65 ++++++++++++++++++++-----------------
 swh/loader/cvs/tests/test_loader.py |  3 ++
 3 files changed, 40 insertions(+), 29 deletions(-)

Changes applied before test

commit 6d8a74f44f47f9a5f31146a25aaf21be7cc218e5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:36:07 2021 +0200

    Ignore generated .so files
    
    They are in this location when installing in development mode.

commit 6d6c456b487b2e671867fafa8ed34a5cbb604176
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:34:37 2021 +0200

    Use lazy substitution for logging + fix error messages
    
    eg. self.log.exception already include the exception (and its traceback),
    so it does not need to be part of the message.

commit b8ceb52f45493354425d73f28198b58444a2ccbb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 17 16:28:52 2021 +0200

    load_status should not be 'uneventful' if the snapshot changed
    
    Even if the revision was already loaded; it might have been for
    a different origin.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/24/ for more details.

Harbormaster completed remote builds in B23869: Diff 22939.Sep 21 2021, 6:01 PM