Differential D6280

converters: Add typing
ClosedPublic
Actions

Authored by vlorentz on Sep 16 2021, 1:43 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDGf413e171b6e0: converters: Add typing

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 16 2021, 1:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 16 2021, 1:43 PM

Build is green

Patch application report for D6280 (id=22743)

Rebasing onto 85eb54015c...

Current branch diff-target is up to date.

Changes applied before test

commit f413e171b6e0ffd703613089bdfbee24dc048bda
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 16 13:39:59 2021 +0200

    converters: Add typing

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/105/ for more details.

Harbormaster completed remote builds in B23674: Diff 22743.Sep 16 2021, 1:45 PM

vlorentz requested review of this revision.Sep 16 2021, 1:45 PM

Interesting [1]

Thanks.

[1] https://docs.python.org/3/library/typing.html#typing.cast

This revision is now accepted and ready to land.Sep 16 2021, 2:13 PM

Closed by commit rDLDGf413e171b6e0: converters: Add typing (authored by vlorentz). · Explain WhySep 17 2021, 12:27 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDGf413e171b6e0: converters: Add typing.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

converters.py

30 lines

Diff 22776

View Options

swh/loader/git/converters.py

converters: Add typingClosedPublicActions