msgpack.unpackb: Use raw=False when possible.
ClosedPublic
Actions

Authored by vlorentz on Nov 5 2018, 5:03 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDCOREc900670dc9a5: msgpack.unpackb: Use raw=False when possible.

Summary

PendingDeprecationWarning: encoding is deprecated, Use raw=False instead.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 5 2018, 5:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 5 2018, 5:03 PM

Comment.

Harbormaster completed remote builds in B2044: Diff 1941.Nov 5 2018, 5:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/11/ for more details.

I've tried this before too, but we can't do that yet, because the version of msgpack we use in Debian stable doesn't yet have raw=False.

cc: @olasd with whom I've discussed this in the past

This revision now requires changes to proceed.Nov 5 2018, 5:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/12/ for more details.

Harbormaster completed remote builds in B2045: Diff 1942.Nov 5 2018, 5:06 PM

The fallback to encoding='utf-8' should fix that issue

Oh, silly me, I commented without checking that first.
Fine by me then :) Thanks!

This revision is now accepted and ready to land.Nov 5 2018, 5:09 PM

Closed by commit rDCOREc900670dc9a5: msgpack.unpackb: Use raw=False when possible. (authored by vlorentz). · Explain WhyNov 5 2018, 5:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

core/

serializers.py

7 lines

Diff 1943

View Options

msgpack.unpackb: Use raw=False when possible.ClosedPublicActions