Differential D6224

api/vault: Fix TypeError caused by unexpected return type of the vault API
ClosedPublic
Actions

Authored by vlorentz on Sep 9 2021, 2:30 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS237cff07ff32: api/vault: Fix TypeError caused by unexpected return type of the vault API

Summary

The vault API returns CoreSWHID, but mocks in tests returned strings...

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23471
Build 36621: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36620: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 9 2021, 2:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 9 2021, 2:30 PM

Build is green

Patch application report for D6224 (id=22524)

Rebasing onto edb6bc332a...

Current branch diff-target is up to date.

Changes applied before test

commit 237cff07ff328e4be91693412300c691496bbc03
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 9 14:29:52 2021 +0200

    api/vault: Fix TypeError caused by unexpected return type of the vault API
    
    The vault API returns CoreSWHID, but mocks in tests returned strings...

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1101/ for more details.

Harbormaster completed remote builds in B23471: Diff 22524.Sep 9 2021, 2:44 PM

vlorentz requested review of this revision.Sep 9 2021, 2:44 PM

anlambert accepted this revision.Sep 9 2021, 2:49 PM

This revision is now accepted and ready to land.Sep 9 2021, 2:49 PM

Closed by commit rDWAPPS237cff07ff32: api/vault: Fix TypeError caused by unexpected return type of the vault API (authored by vlorentz). · Explain WhySep 9 2021, 2:50 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS237cff07ff32: api/vault: Fix TypeError caused by unexpected return type of the vault API.