Differential D621

Fix GitLoaderFromArchive.
ClosedPublic
Actions

Authored by vlorentz on Oct 30 2018, 3:45 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDLDGd35881f5fe29: Fix GitLoaderFromArchive.

Summary

SWHLoader calls prepare(); and if prepare() fails, it calls cleanup().
However, GitLoaderFromArchive.cleanup() uses self.temp_dir and self.repo_path,
so they have to be initialized.

Additionally, GitLoaderFromArchive.prepare_origin_visit does not accept
the same argument name as its parent, so it fails when called by
GitLoaderFromArchive.load.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 30 2018, 3:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 30 2018, 3:45 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/12/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/12/console

Harbormaster failed remote builds in B2001: Diff 1910!Oct 30 2018, 3:46 PM

vlorentz added a child revision: D622: New tests for the Git loader..Oct 30 2018, 3:47 PM

Rebase

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/15/ for more details.

Harbormaster completed remote builds in B2007: Diff 1916.Oct 30 2018, 6:11 PM

olasd accepted this revision.Oct 30 2018, 6:14 PM

This revision is now accepted and ready to land.Oct 30 2018, 6:14 PM

Closed by commit rDLDGd35881f5fe29: Fix GitLoaderFromArchive. (authored by vlorentz). · Explain WhyOct 31 2018, 10:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

12 lines

Diff 1920

swh/loader/git/loader.py

Loading...