common/utils: Add function to get origin visit types dynamically
ClosedPublic
Actions

Authored by anlambert on Sep 8 2021, 5:42 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3441: Implement query to get origin visit types dynamically

Commits

rDWAPPS3d6abb9ae1ae: common/utils: Add function to get origin visit types dynamically

Summary

Instead of hardcoding the list of visit types that can be used in
search queries, retrieve it dynamically using swh-search.

Also remove visit_types from global template context processor
and move it to seach related views only to avoid sending a
request to elasticsearch on every page load.

Related to T3441

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-visit-types-from-search

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23449
Build 36592: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36591: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 8 2021, 5:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 8 2021, 5:42 PM

Build is green

Patch application report for D6219 (id=22499)

Rebasing onto e2b48563ac...

Current branch diff-target is up to date.

Changes applied before test

commit 3d6abb9ae1ae4fda752bfc58b9fffcfc4f0d985f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 8 16:43:58 2021 +0200

    common/utils: Add function to get origin visit types dynamically
    
    Instead of hardcoding the list of visit types that can be used in
    search queries, retrieve it dynamically using swh-search.
    
    Also remove visit_types from global template context processor
    and move it to seach related views only to avoid sending a
    request to elasticsearch on every page load.
    
    Related to T3441

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1098/ for more details.

Harbormaster completed remote builds in B23449: Diff 22499.Sep 8 2021, 5:55 PM

anlambert requested review of this revision.Sep 8 2021, 5:55 PM

ardumont accepted this revision.Sep 9 2021, 10:13 AM

This revision is now accepted and ready to land.Sep 9 2021, 10:13 AM

Closed by commit rDWAPPS3d6abb9ae1ae: common/utils: Add function to get origin visit types dynamically (authored by anlambert). · Explain WhySep 9 2021, 10:50 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS3d6abb9ae1ae: common/utils: Add function to get origin visit types dynamically.