Differential D6161

postgresql: Fix a column order mismatch between the query and object builder
ClosedPublic
Actions

Authored by vsellier on Aug 30 2021, 5:06 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3539: snapshot/metadata inversion in origin_visit_status_get_random

Commits

rDSTO3ad1bec113e8: postgresql: Fix a column order mismatch between the query and object builder

Summary

resulting in OriginVisitStatus trying to put a snapshot id in the
metadata field

Related to T3539

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Aug 30 2021, 5:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2021, 5:06 PM

Build is green

Patch application report for D6161 (id=22316)

Rebasing onto 47a6919fee...

Current branch diff-target is up to date.

Changes applied before test

commit f5b573c26acc9768e547efa468f8dc1467b0843b
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Aug 30 16:55:57 2021 +0200

    postgresql: Fix a column order mismatch between the query and object builder
    
    resulting in OriginVisitStatus trying to put a snapshot id in the
    metadata field
    
    Related to T3539

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1388/ for more details.

Harbormaster completed remote builds in B23270: Diff 22316.Aug 30 2021, 5:12 PM

vsellier requested review of this revision.Aug 30 2021, 5:12 PM

Add a failure without the correction in the tests

Build is green

Patch application report for D6161 (id=22317)

Rebasing onto 47a6919fee...

Current branch diff-target is up to date.

Changes applied before test

commit 492dada45ab0aba0f0150234967afa849b9a510f
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Aug 30 16:55:57 2021 +0200

    postgresql: Fix a column order mismatch between the query and object builder
    
    resulting in OriginVisitStatus trying to put a snapshot id in the
    metadata field
    
    Related to T3539

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1389/ for more details.

Harbormaster completed remote builds in B23271: Diff 22317.Aug 30 2021, 5:30 PM

rebase

Nice catch.

This revision is now accepted and ready to land.Aug 30 2021, 5:45 PM

Build has FAILED

Patch application report for D6161 (id=22320)

Rebasing onto 999ea6bbd7...

Current branch diff-target is up to date.

Changes applied before test

commit 3ad1bec113e885bacf1089701d1b150780e6efaf
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Aug 30 16:55:57 2021 +0200

    postgresql: Fix a column order mismatch between the query and object builder
    
    resulting in OriginVisitStatus trying to put a snapshot id in the
    metadata field
    
    Related to T3539

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1391/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1391/console

Harbormaster failed remote builds in B23274: Diff 22320!Aug 30 2021, 5:47 PM

Build is green

Patch application report for D6161 (id=22320)

Rebasing onto 999ea6bbd7...

Current branch diff-target is up to date.

Changes applied before test

commit 3ad1bec113e885bacf1089701d1b150780e6efaf
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Aug 30 16:55:57 2021 +0200

    postgresql: Fix a column order mismatch between the query and object builder
    
    resulting in OriginVisitStatus trying to put a snapshot id in the
    metadata field
    
    Related to T3539

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1392/ for more details.

Harbormaster completed remote builds in B23274: Diff 22320.Aug 30 2021, 5:54 PM

Closed by commit rDSTO3ad1bec113e8: postgresql: Fix a column order mismatch between the query and object builder (authored by vsellier). · Explain WhyAug 31 2021, 9:18 AM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDSTO3ad1bec113e8: postgresql: Fix a column order mismatch between the query and object builder.