Differential D6143

Add support for 'development' installs
ClosedPublic
Actions

Authored by vlorentz on Aug 26 2021, 12:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSEA4f01acc1a3b7: Add support for 'development' installs

Summary

aka. 'pip install -e' or 'python3 setup.py develop'.

This is done by compiling a temporary .so at runtime.

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 26 2021, 12:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 26 2021, 12:46 PM

Build is green

Patch application report for D6143 (id=22239)

Rebasing onto 3940daa889...

Current branch diff-target is up to date.

Changes applied before test

commit 4f01acc1a3b78da81ae22cdd0861bc71f8224f57
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 26 12:46:20 2021 +0200

    Add support for 'development' installs
    
    aka. 'pip install -e' or 'python3 setup.py develop'.
    
    This is done by compiling a temporary .so at runtime.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/286/ for more details.

Harbormaster completed remote builds in B23197: Diff 22239.Aug 26 2021, 12:50 PM

vlorentz requested review of this revision.Aug 26 2021, 12:50 PM

lgtm

As far as i understood, this is needed to allow development on swh-search.

Shouldn't this be explained in the docs somewhere though?

This revision is now accepted and ready to land.Aug 30 2021, 4:51 PM

In D6143#159345, @ardumont wrote:

As far as i understood, this is needed to allow development on swh-search.

Not needed, but very helpful

Shouldn't this be explained in the docs somewhere though?

What part?

In D6143#159424, @vlorentz wrote:

In D6143#159345, @ardumont wrote:

As far as i understood, this is needed to allow development on swh-search.

Not needed, but very helpful

Shouldn't this be explained in the docs somewhere though?

What part?