... as in the missing retries_left configuration.
- Also add test on that function.
Related D608#inline-2891
Details
Details
tox
Diff Detail
Diff Detail
- Repository
- rDSCH Scheduling utilities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1959 Build 2364: tox-on-jenkins Jenkins Build 2363: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/18/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/19/ for more details.
Comment Actions
As there is no copy of kwargs, the new for loop also modifies task['arguments']['kwargs'].
Although this is the correct behavior, it's not obvious it happens when reading the code. I suggest rewriting the function like this:
task_extra = {}
for extra_key in ['priority', 'retries_left']:
if extra_key in kwargs:
extra_val = kwargs.pop(extra_key)
task_extra[extra_key] = extra_val
task = {
'policy': policy,
# ...
}
task.update(task_extra)Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/21/ for more details.