Page MenuHomeSoftware Heritage

Add new 'deprecated' tag for API routes, and 'un-hide' deprecate vault routes from the index
ClosedPublic

Authored by vlorentz on Aug 25 2021, 1:31 PM.

Diff Detail

Repository
rDWAPPS Web applications
Branch
vault
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23151
Build 36114: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36113: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6132 (id=22193)

Could not rebase; Attempt merge onto 773d6c2e06...

Updating 773d6c2e..5ba1f0bf
Fast-forward
 assets/src/bundles/vault/vault-create-tasks.js     |  50 ++--
 assets/src/bundles/vault/vault-table-row.ejs       |  18 +-
 assets/src/bundles/vault/vault-ui.js               |  65 +++--
 ...d19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} | Bin
 ...a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} | Bin
 cypress/integration/vault.spec.js                  | 114 +++++----
 swh/web/api/apidoc.py                              |   1 +
 swh/web/api/views/vault.py                         | 269 ++++++++++++++-------
 swh/web/browse/snapshot_context.py                 |   4 +-
 swh/web/browse/urls.py                             |   6 +-
 swh/web/browse/views/directory.py                  |   4 +-
 swh/web/browse/views/release.py                    |   8 +-
 swh/web/browse/views/revision.py                   |   6 +-
 swh/web/common/archive.py                          |  25 +-
 swh/web/templates/api/endpoints.html               |   3 +-
 swh/web/templates/includes/vault-create-tasks.html |  22 +-
 swh/web/tests/api/views/test_vault.py              | 230 +++++++++++++++---
 17 files changed, 560 insertions(+), 265 deletions(-)
 rename cypress/fixtures/{cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz => swh:1:dir:cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} (100%)
 rename cypress/fixtures/{1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz => swh:1:rev:1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} (100%)
Changes applied before test
commit 5ba1f0bfcfa20e79b0ae6e8ffdcefb3b1d2b0785
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 25 13:30:16 2021 +0200

    Add new 'deprecated' tag for API routes, and 'un-hide' deprecate vault routes from the index

commit 8d735fb8de9f96c9245e3da636f4485e2108dacf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 24 16:17:28 2021 +0200

    Remove page refresh hack from updateVaultItemList.
    
    It's brittle, and not the right place.

commit c402ae6a4ca6355519903c5c61f11fa4f81ccb7a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 18 19:02:10 2021 +0200

    vault API: Rename bundle types and use SWHIDs to identify objects
    
    This is to match changes in the vault interface, see D6112 for the rationale.
    
    All existing queries still work, through "fallback" views.  There are
    some minor changes in returned fields (removed obj_type, and replace
    obj_id with swhid), but I don't think anyone used them (since that info
    is already available to them before they send the request).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1029/ for more details.

vlorentz edited the summary of this revision. (Show Details)

oops, wasn't supposed to be in this diff

Build is green

Patch application report for D6132 (id=22213)

Could not rebase; Attempt merge onto 773d6c2e06...

Updating 773d6c2e..db9c826d
Fast-forward
 assets/src/bundles/vault/vault-create-tasks.js     |  50 ++--
 assets/src/bundles/vault/vault-table-row.ejs       |  18 +-
 assets/src/bundles/vault/vault-ui.js               |  65 +++--
 ...d19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} | Bin
 ...a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} | Bin
 cypress/integration/vault.spec.js                  | 114 +++++----
 swh/web/api/apidoc.py                              |   1 +
 swh/web/api/views/vault.py                         | 269 ++++++++++++++-------
 swh/web/browse/snapshot_context.py                 |   4 +-
 swh/web/browse/urls.py                             |   6 +-
 swh/web/browse/views/directory.py                  |   4 +-
 swh/web/browse/views/release.py                    |   8 +-
 swh/web/browse/views/revision.py                   |   6 +-
 swh/web/common/archive.py                          |  25 +-
 swh/web/templates/api/endpoints.html               |   3 +-
 swh/web/templates/includes/vault-create-tasks.html |  22 +-
 swh/web/tests/api/views/test_vault.py              | 230 +++++++++++++++---
 17 files changed, 560 insertions(+), 265 deletions(-)
 rename cypress/fixtures/{cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz => swh:1:dir:cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} (100%)
 rename cypress/fixtures/{1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz => swh:1:rev:1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} (100%)
Changes applied before test
commit db9c826dbdcabb439f4dbec52c6a04d51ee362d2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 25 13:30:16 2021 +0200

    Add new 'deprecated' tag for API routes, and 'un-hide' deprecate vault routes from the index

commit 8d735fb8de9f96c9245e3da636f4485e2108dacf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 24 16:17:28 2021 +0200

    Remove page refresh hack from updateVaultItemList.
    
    It's brittle, and not the right place.

commit c402ae6a4ca6355519903c5c61f11fa4f81ccb7a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 18 19:02:10 2021 +0200

    vault API: Rename bundle types and use SWHIDs to identify objects
    
    This is to match changes in the vault interface, see D6112 for the rationale.
    
    All existing queries still work, through "fallback" views.  There are
    some minor changes in returned fields (removed obj_type, and replace
    obj_id with swhid), but I don't think anyone used them (since that info
    is already available to them before they send the request).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1031/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Aug 26 2021, 10:32 AM

Build is green

Patch application report for D6132 (id=22214)

Could not rebase; Attempt merge onto 773d6c2e06...

Updating 773d6c2e..a45155af
Fast-forward
 assets/src/bundles/vault/vault-create-tasks.js     |  50 ++--
 assets/src/bundles/vault/vault-table-row.ejs       |  18 +-
 assets/src/bundles/vault/vault-ui.js               |  65 +++--
 ...d19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} | Bin
 ...a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} | Bin
 cypress/integration/vault.spec.js                  | 114 +++++----
 swh/web/api/apidoc.py                              |   1 +
 swh/web/api/views/vault.py                         | 269 ++++++++++++++-------
 swh/web/browse/snapshot_context.py                 |   4 +-
 swh/web/browse/urls.py                             |   6 +-
 swh/web/browse/views/directory.py                  |   4 +-
 swh/web/browse/views/release.py                    |   8 +-
 swh/web/browse/views/revision.py                   |   6 +-
 swh/web/common/archive.py                          |  25 +-
 swh/web/templates/api/endpoints.html               |   3 +-
 swh/web/templates/includes/vault-create-tasks.html |  22 +-
 swh/web/tests/api/views/test_vault.py              | 230 +++++++++++++++---
 17 files changed, 560 insertions(+), 265 deletions(-)
 rename cypress/fixtures/{cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz => swh:1:dir:cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} (100%)
 rename cypress/fixtures/{1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz => swh:1:rev:1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} (100%)
Changes applied before test
commit a45155af916365367175709b93663feaa5b91071
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 25 13:30:16 2021 +0200

    Add new 'deprecated' tag for API routes, and 'un-hide' deprecate vault routes from the index

commit 8d735fb8de9f96c9245e3da636f4485e2108dacf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 24 16:17:28 2021 +0200

    Remove page refresh hack from updateVaultItemList.
    
    It's brittle, and not the right place.

commit c402ae6a4ca6355519903c5c61f11fa4f81ccb7a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 18 19:02:10 2021 +0200

    vault API: Rename bundle types and use SWHIDs to identify objects
    
    This is to match changes in the vault interface, see D6112 for the rationale.
    
    All existing queries still work, through "fallback" views.  There are
    some minor changes in returned fields (removed obj_type, and replace
    obj_id with swhid), but I don't think anyone used them (since that info
    is already available to them before they send the request).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1032/ for more details.