Paths

Table of Contentst

swh.scheduler.utils: Allow to add more task information
ClosedPublic
Actions

Authored by ardumont on Oct 26 2018, 8:36 PM.

Details

Reviewers

Commits

rDSCHe51e9ff0db04: swh.scheduler.utils: Improve implementation to clarify intent
rDSCHeefe310728eb: swh.scheduler.utils: Allow to add more task information

Summary

... as in the missing retries_left configuration.

Also add test on that function.

Related D608#inline-2891

Test Plan

tox

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 26 2018, 8:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/18/ for more details.

Harbormaster completed remote builds in B1959: Diff 1871.Oct 26 2018, 8:39 PM

No change, just plug the diff to branch 'update-utils'.

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/19/ for more details.

Harbormaster completed remote builds in B1961: Diff 1873.Oct 26 2018, 9:33 PM

As there is no copy of kwargs, the new for loop also modifies task['arguments']['kwargs'].

Although this is the correct behavior, it's not obvious it happens when reading the code. I suggest rewriting the function like this:

task_extra = {}
for extra_key in ['priority', 'retries_left']:
    if extra_key in kwargs:
        extra_val = kwargs.pop(extra_key)
        task_extra[extra_key] = extra_val

task = {
    'policy': policy,
    # ...
}
task.update(task_extra)

This revision now requires changes to proceed.Oct 29 2018, 9:19 AM

swh.scheduler.utils: Improve implementation to clarify intent

vlorentz accepted this revision.Oct 29 2018, 9:36 AM

This revision is now accepted and ready to land.Oct 29 2018, 9:36 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/21/ for more details.

Harbormaster completed remote builds in B1965: Diff 1877.Oct 29 2018, 9:36 AM

Closed by commit rDSCHeefe310728eb: swh.scheduler.utils: Allow to add more task information (authored by ardumont). · Explain WhyOct 29 2018, 9:39 AM

This revision was automatically updated to reflect the committed changes.

ardumont mentioned this in rDCIDXb60c94cfd857: swh.indexer.tests: Fix dict format.Oct 29 2018, 10:31 AM

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

tests/

test_utils.py

25 lines

utils.py

13 lines

Diff 1878

View Options

swh/scheduler/tests/test_utils.py