Page MenuHomeSoftware Heritage
Differential D610

swh.journal.publisher: Process snapshots
ClosedPublic
Actions

Authored by ardumont on Oct 26 2018, 6:58 PM.

Details

Reviewers
olasd
Commits
rDJNLa5093c1b4ecb: swh.journal.publisher: Process snapshots
rDJNL68956c73cdb0: swh.journal.publisher: Document publisher
Summary

As a first commit, i updated the publisher's docstring.

Related T1275

Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
add-snapshot
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1957
Build 2361: tox-on-jenkinsJenkins
Build 2360: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 26 2018, 6:58 PM
swh-public-ci added a subscriber: swh-public-ci.Oct 26 2018, 7:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/10/ for more details.

Harbormaster completed remote builds in B1955: Diff 1867.Oct 26 2018, 7:00 PM
ardumont marked an inline comment as done.Oct 26 2018, 7:02 PM

And i miss at least one basic test on the snapshot insertion...

swh/journal/publisher.py
139

Here is what i meant about missing origin.
Not on the storage.listener, on the journal.publisher (not sure i was clear).

ardumont edited the summary of this revision. (Show Details)Oct 26 2018, 7:07 PM
ardumont updated this revision to Diff 1869.EditedOct 26 2018, 7:21 PM

And i miss at least one basic test on the snapshot insertion...

  • swh.journal.tests: Add process snapshot scenario

Done ;)

ardumont edited the test plan for this revision. (Show Details)Oct 26 2018, 7:21 PM
swh-public-ci added a comment.Oct 26 2018, 7:22 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/11/ for more details.

Harbormaster completed remote builds in B1957: Diff 1869.Oct 26 2018, 7:22 PM
olasd accepted this revision.Nov 6 2018, 11:52 AM
This revision is now accepted and ready to land.Nov 6 2018, 11:52 AM
Closed by commit rDJNL68956c73cdb0: swh.journal.publisher: Document publisher (authored by ardumont). · Explain WhyNov 7 2018, 9:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
debian/
5 lines
2 lines
swh/
journal/
71 lines
tests/
33 lines

Diff 1869

View Options

debian/control

Loading...
View Options

requirements-swh.txt

Loading...
View Options

swh/journal/publisher.py

Loading...
View Options

swh/journal/tests/test_publisher.py

Loading...
About · Developer information · Legal