swh.journal.publisher: Process snapshots
ClosedPublic
Actions

Authored by ardumont on Oct 26 2018, 6:58 PM.

Details

Reviewers

Commits

rDJNLa5093c1b4ecb: swh.journal.publisher: Process snapshots
rDJNL68956c73cdb0: swh.journal.publisher: Document publisher

Summary

As a first commit, i updated the publisher's docstring.

Related T1275

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 26 2018, 6:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/10/ for more details.

Harbormaster completed remote builds in B1955: Diff 1867.Oct 26 2018, 7:00 PM

And i miss at least one basic test on the snapshot insertion...

swh/journal/publisher.py
138	Here is what i meant about missing origin. Not on the storage.listener, on the journal.publisher (not sure i was clear).

ardumont edited the summary of this revision. (Show Details)Oct 26 2018, 7:07 PM

And i miss at least one basic test on the snapshot insertion...

swh.journal.tests: Add process snapshot scenario

Done ;)

ardumont edited the test plan for this revision. (Show Details)Oct 26 2018, 7:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/11/ for more details.

Harbormaster completed remote builds in B1957: Diff 1869.Oct 26 2018, 7:22 PM

olasd accepted this revision.Nov 6 2018, 11:52 AM

This revision is now accepted and ready to land.Nov 6 2018, 11:52 AM

Closed by commit rDJNL68956c73cdb0: swh.journal.publisher: Document publisher (authored by ardumont). · Explain WhyNov 7 2018, 9:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

publisher.py

60 lines

Diff 1950

View Options

swh.journal.publisher: Process snapshotsClosedPublicActions