Page MenuHomeSoftware Heritage

Add logging instead of silently ignoring GraphArgumentException.
ClosedPublic

Authored by vlorentz on Aug 5 2021, 12:41 PM.

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6058 (id=21919)

Could not rebase; Attempt merge onto a5054749dd...

Updating a505474..b7438cc
Fast-forward
 requirements-swh.txt          |  2 +-
 swh/vault/cookers/base.py     | 10 +++--
 swh/vault/cookers/git_bare.py | 85 ++++++++++++++++++++++++++++++-------------
 3 files changed, 67 insertions(+), 30 deletions(-)
Changes applied before test
commit b7438ccb3f9f33f13fea62c7ca3f6f612f7df459
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 5 12:41:00 2021 +0200

    Add logging instead of silently ignoring GraphArgumentException.

commit 13d9247bf19378bdaf4929fc857f5babffec489b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 5 12:39:26 2021 +0200

    Add typing, and fix potential issues found by mypy.

commit 3c524f63772bebe3464af2299b34d8196f7f35a7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 16:56:39 2021 +0200

    Don't hide git-fsck errort messages, even when none is expected

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/148/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/148/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2021, 12:45 PM
Harbormaster failed remote builds in B22887: Diff 21919!

Build is green

Patch application report for D6058 (id=21924)

Could not rebase; Attempt merge onto a5054749dd...

Updating a505474..8b78841
Fast-forward
 requirements-swh.txt          |  2 +-
 swh/vault/cookers/base.py     | 10 +++--
 swh/vault/cookers/git_bare.py | 91 ++++++++++++++++++++++++++++++-------------
 3 files changed, 72 insertions(+), 31 deletions(-)
Changes applied before test
commit 8b78841bd0700f7e856f53944ff8cd0867b2455d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 5 12:41:00 2021 +0200

    Add logging instead of silently ignoring GraphArgumentException.

commit e61a2494d41874140e47ec02844802b3123f945d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 5 12:39:26 2021 +0200

    Add typing, and fix potential issues found by mypy.

commit b290a199fcfdd9c0211f8e5dd79b63b368663473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 16:56:39 2021 +0200

    Don't hide git-fsck error messages, even when none is expected

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/151/ for more details.

This revision is now accepted and ready to land.Aug 5 2021, 3:19 PM

Build is green

Patch application report for D6058 (id=21927)

Could not rebase; Attempt merge onto a5054749dd...

Updating a505474..149b1c1
Fast-forward
 requirements-swh.txt          |  2 +-
 swh/vault/cookers/base.py     | 10 +++--
 swh/vault/cookers/git_bare.py | 91 +++++++++++++++++++++++++++++++------------
 3 files changed, 73 insertions(+), 30 deletions(-)
Changes applied before test
commit 149b1c1c317370713bc64d3824ae6ce5df8752fd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 5 12:41:00 2021 +0200

    Add logging instead of silently ignoring GraphArgumentException.

commit 8065b392967e4932f3e33e51ab604d6957ad4723
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 5 12:39:26 2021 +0200

    Add typing, and fix potential issues found by mypy.

commit b290a199fcfdd9c0211f8e5dd79b63b368663473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 16:56:39 2021 +0200

    Don't hide git-fsck error messages, even when none is expected

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/153/ for more details.