Page MenuHomeSoftware Heritage

Don't hide git-fsck error messages, even when none is expected
ClosedPublic

Authored by vlorentz on Aug 5 2021, 12:40 PM.

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6056 (id=21917)

Rebasing onto a5054749dd...

Current branch diff-target is up to date.
Changes applied before test
commit 3c524f63772bebe3464af2299b34d8196f7f35a7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 16:56:39 2021 +0200

    Don't hide git-fsck errort messages, even when none is expected

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/146/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/146/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2021, 12:42 PM
Harbormaster failed remote builds in B22885: Diff 21917!

Build is green

Patch application report for D6056 (id=21922)

Rebasing onto a5054749dd...

Current branch diff-target is up to date.
Changes applied before test
commit b290a199fcfdd9c0211f8e5dd79b63b368663473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 16:56:39 2021 +0200

    Don't hide git-fsck error messages, even when none is expected

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/149/ for more details.

ardumont added a subscriber: ardumont.

ok

typo in the title "errort".

One question inline.

swh/vault/cookers/git_bare.py
149

is the blank after warning expected?

This revision is now accepted and ready to land.Aug 5 2021, 3:05 PM
vlorentz retitled this revision from Don't hide git-fsck errort messages, even when none is expected to Don't hide git-fsck error messages, even when none is expected.Aug 5 2021, 3:22 PM
vlorentz added inline comments.
swh/vault/cookers/git_bare.py
149

yes