Page MenuHomeSoftware Heritage
Differential D6040

test: Make the child process wait longer so it gets actually killed
ClosedPublic
Actions

Authored by ardumont on Jul 28 2021, 4:36 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDHGcae036cac707: test: Make the child process wait longer so it gets actually killed
Summary

Prior to this, depending on the load on jenkins, the test could be flaky and fail for
the wrong reason [1]

[1] https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/263/console

Test Plan

tox ok

Also D6043 based on this is no longer failing for the wrong reason.

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 28 2021, 4:36 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 28 2021, 4:36 PM
swh-public-ci added a comment.Jul 28 2021, 4:38 PM

Build is green

Patch application report for D6040 (id=21839)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit 24022090b250cfa3059536af696f1a0b55cda39c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    Debug hgutils flakiness

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/264/ for more details.

Harbormaster completed remote builds in B22801: Diff 21839.Jul 28 2021, 4:38 PM
ardumont requested review of this revision.Jul 28 2021, 4:38 PM
ardumont updated this revision to Diff 21840.Jul 28 2021, 4:39 PM

Make it consistently fail... This diff is the same old behavior as the current master
which is somehow flaky but only in diffs (wth?!)

swh-public-ci added a comment.Jul 28 2021, 4:40 PM

Build has FAILED

Patch application report for D6040 (id=21840)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit 83e6d08c0ea8e07bd31f9b844cc81028771f9b5c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    Debug hgutils flakiness

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/265/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/265/console

Harbormaster failed remote builds in B22802: Diff 21840!Jul 28 2021, 4:40 PM
ardumont edited the summary of this revision. (Show Details)Jul 28 2021, 4:41 PM
ardumont retitled this revision from Debug hgutils flakiness to Debug hgutils flakiness 1/2.
ardumont added inline comments.Jul 28 2021, 4:50 PM
swh/loader/mercurial/hgutil.py
163

prior to this, we waited 0.9 second instead of the 1 second the comment claimed.

vlorentz added a subscriber: vlorentz.Jul 28 2021, 4:50 PM
vlorentz added inline comments.
swh/loader/mercurial/hgutil.py
163

Are you sure about this?

>>> len(range(10))
10
ardumont added inline comments.Jul 28 2021, 4:56 PM
swh/loader/mercurial/hgutil.py
163

oh yeah, right, it starts at 0, i messed up ;)
fixing.

Still, the stuff fails nonetheless ;)
Thanks.

ardumont updated this revision to Diff 21843.Jul 28 2021, 4:57 PM
  • Print with utcnow() all around
  • revert range(11) to range(10) as before
swh-public-ci added a comment.Jul 28 2021, 4:59 PM

Build has FAILED

Patch application report for D6040 (id=21843)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit 566c65f47746abfc85e0e8a54025f97100ad7556
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    Debug hgutils flakiness

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/267/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/267/console

Harbormaster failed remote builds in B22805: Diff 21843!Jul 28 2021, 4:59 PM
ardumont edited the test plan for this revision. (Show Details)Jul 28 2021, 4:59 PM
ardumont updated this revision to Diff 21845.Jul 28 2021, 5:15 PM

Make the sleepy time longer

swh-public-ci added a comment.Jul 28 2021, 5:17 PM

Build is green

Patch application report for D6040 (id=21845)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit 519629942604d026cb515f7fe9f2e327af4c8e04
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    Debug hgutils flakiness

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/269/ for more details.

Harbormaster completed remote builds in B22807: Diff 21845.Jul 28 2021, 5:17 PM
ardumont added a child revision: D6043: [duplicated] Use versioned ExtIDs in main loader mercurial implementation.Jul 28 2021, 5:18 PM
ardumont updated this revision to Diff 21848.Jul 28 2021, 5:28 PM

Drop unnecessary changes.

ardumont retitled this revision from Debug hgutils flakiness 1/2 to test: Make the child process wait longer so it gets actually killed.Jul 28 2021, 5:29 PM
ardumont edited the summary of this revision. (Show Details)
ardumont edited the test plan for this revision. (Show Details)
swh-public-ci added a comment.Jul 28 2021, 5:29 PM

Build is green

Patch application report for D6040 (id=21848)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit 61ec738eacfd93de4cccb545dae5de8a65429ee2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    test: Make the child process wait longer so it gets actually killed
    
    Prior to this, depending on the load on jenkins, the test could be flaky and fail for
    the wrong reason [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/263/console

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/272/ for more details.

Harbormaster completed remote builds in B22810: Diff 21848.Jul 28 2021, 5:29 PM
ardumont added a child revision: D6036: Use versioned ExtIDs in loader mercurial implementation.Jul 28 2021, 5:30 PM
ardumont marked an inline comment as done.
ardumont updated this revision to Diff 21850.Jul 28 2021, 5:34 PM
ardumont edited the summary of this revision. (Show Details)
ardumont edited the test plan for this revision. (Show Details)

Revert some more unneeded changes

swh-public-ci added a comment.Jul 28 2021, 5:36 PM

Build is green

Patch application report for D6040 (id=21850)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit d93fa51dbd0cb2c7a9e57c3a98c6b96d0cac8d43
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    test: Make the child process wait longer so it gets actually killed
    
    Prior to this, depending on the load on jenkins, the test could be flaky and fail for
    the wrong reason [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/263/console

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/274/ for more details.

Harbormaster completed remote builds in B22812: Diff 21850.Jul 28 2021, 5:36 PM
vlorentz accepted this revision.Jul 28 2021, 5:44 PM
vlorentz added inline comments.
swh/loader/mercurial/tests/test_hgutil.py
22

not needed, it's in the closure

This revision is now accepted and ready to land.Jul 28 2021, 5:44 PM
ardumont added inline comments.Jul 28 2021, 5:47 PM
swh/loader/mercurial/tests/test_hgutil.py
22

I never know when it is in the closure and when it's not.

How can i tell?

ardumont updated this revision to Diff 21852.Jul 28 2021, 5:48 PM

Drop unnecessary instruction according to suggestion.

swh-public-ci added a comment.Jul 28 2021, 5:50 PM

Build is green

Patch application report for D6040 (id=21852)

Rebasing onto f3232bfd67...

Current branch diff-target is up to date.
Changes applied before test
commit cae036cac707c07dc083aa134c59fcd48e3b313c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 28 16:35:59 2021 +0200

    test: Make the child process wait longer so it gets actually killed
    
    Prior to this, depending on the load on jenkins, the test could be flaky and fail for
    the wrong reason [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/263/console

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/276/ for more details.

Harbormaster completed remote builds in B22814: Diff 21852.Jul 28 2021, 5:50 PM
vlorentz added inline comments.Jul 28 2021, 5:55 PM
swh/loader/mercurial/tests/test_hgutil.py
22

it's in the closure iff the name appears in the function body and the function never assigns it.

vlorentz added inline comments.Jul 28 2021, 5:56 PM
swh/loader/mercurial/tests/test_hgutil.py
22

never assigns it

that's determined statically btw, so if you do if False: sleepy_time = 42 anywhere in the function, it wouldn't be in the closure

ardumont added inline comments.Jul 28 2021, 5:57 PM
swh/loader/mercurial/tests/test_hgutil.py
22

thanks!

Closed by commit rDLDHGcae036cac707: test: Make the child process wait longer so it gets actually killed (authored by ardumont). · Explain WhyJul 29 2021, 10:43 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDHGcae036cac707: test: Make the child process wait longer so it gets actually killed.

Revision Contents
Changeset List

PathSize
swh/
loader/
mercurial/
3 lines
tests/
6 lines

Diff 21856

View Options

swh/loader/mercurial/hgutil.py

Loading...
View Options

swh/loader/mercurial/tests/test_hgutil.py

Loading...
About · Developer information · Legal