test: Refactor assert_visit_stats_ok to ignore_fields
ClosedPublic
Actions

Authored by ardumont on Jul 23 2021, 9:25 AM.

Details

Reviewers

Group Reviewers

Commits

rDSCH3ca0d659503f: test_journal_client: Unify test assertion like the rest
rDSCH8cf2238eac8d: test: Refactor assert_visit_stats_ok to ignore_fields

Summary

This simplifies and unifies properly the utility test function to compare visit
stats (as done in pair with @olasd)

This also contain another commit which unifies the test assertion like the rest
(reverting what was modified in D5917)

Test Plan

tox

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22720
Build 35432: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35431: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 23 2021, 9:25 AM

Build is green

Patch application report for D6017 (id=21753)

Rebasing onto d58776ab0b...

Current branch diff-target is up to date.

Changes applied before test

commit 3ca0d659503ffce208d643e26d5712f46c28ffae
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 23 09:22:46 2021 +0200

    test_journal_client: Unify test assertion like the rest
    
    Related to D5917

commit 8cf2238eac8d9d14c2e510d4f3a0c7dd0e48d9a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 22 11:42:24 2021 +0200

    test: Refactor assert_visit_stats_ok to ignore_fields
    
    This simplifies and unifies properly the utility test function to compare visit stats.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/418/ for more details.

Harbormaster completed remote builds in B22720: Diff 21753.Jul 23 2021, 9:28 AM

ardumont requested review of this revision.Jul 23 2021, 9:29 AM

olasd accepted this revision.Jul 23 2021, 3:56 PM

This revision is now accepted and ready to land.Jul 23 2021, 3:56 PM

Closed by commit rDSCH8cf2238eac8d: test: Refactor assert_visit_stats_ok to ignore_fields (authored by ardumont). · Explain WhyJul 23 2021, 3:58 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH8cf2238eac8d: test: Refactor assert_visit_stats_ok to ignore_fields.

ardumont added a commit: rDSCH3ca0d659503f: test_journal_client: Unify test assertion like the rest.