Add more varied tests for journal_client.fetch_last_revision_release_date
ClosedPublic
Actions

Authored by olasd on Jul 21 2021, 1:14 PM.

Details

Reviewers

KShivendu
ardumont

Commits

rDSEA0fee7bb45f78: Add more varied tests for journal_client.fetch_last_revision_release_date

Summary

We've noticed some of these issues while deploying to staging

Test Plan

tests added

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 21 2021, 1:14 PM

Build is green

Patch application report for D6011 (id=21719)

Rebasing onto 32cb812a42...

Current branch diff-target is up to date.

Changes applied before test

commit 0fee7bb45f78f137def0525ab82558ef665cc9d5
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jul 21 12:58:01 2021 +0200

    Add more varied tests for journal_client.fetch_last_revision_release_date

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/220/ for more details.

Harbormaster completed remote builds in B22687: Diff 21719.Jul 21 2021, 1:19 PM

olasd requested review of this revision.Jul 21 2021, 1:19 PM

ardumont accepted this revision.Jul 21 2021, 2:17 PM

This revision is now accepted and ready to land.Jul 21 2021, 2:17 PM

Closed by commit rDSEA0fee7bb45f78: Add more varied tests for journal_client.fetch_last_revision_release_date (authored by olasd). · Explain WhyJul 21 2021, 2:23 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSEA0fee7bb45f78: Add more varied tests for journal_client.fetch_last_revision_release_date.

olasd mentioned this in T3433: Deploy swh.search v0.10/v0.11.Jul 21 2021, 5:28 PM

Revision Contents
Changeset List

Path

Size

swh/

search/

journal_client.py

28 lines

tests/

test_journal_client.py

44 lines

Diff 21723

View Options

swh/search/journal_client.py