Page MenuHomeSoftware Heritage

model: make deduplication optional when iterating over the merkle tree
ClosedPublic

Authored by DanSeraf on Jun 30 2021, 4:21 PM.

Diff Detail

Repository
rDMOD Data model
Branch
deduplication-opt
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22399
Build 34890: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 34889: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5951 (id=21375)

Rebasing onto cfb3073c27...

First, rewinding head to replay your work on top of it...
Applying: make deduplication optional when iterating over the merkle tree
Changes applied before test
commit 0406067e666ff4c2af158fd08b50bd5d1b0c4f91
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jun 29 13:42:54 2021 +0100

    make deduplication optional when iterating over the merkle tree

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/362/ for more details.

zack requested changes to this revision.Jul 1 2021, 8:27 PM
zack added a subscriber: zack.

only minor changes requested to the docstring on my part

swh/model/merkle.py
279–283

this docstring should be updated, stating it deduplicate s(or not) depending on dedup's value

289–291

this is a nice solution that avoids creating a separate iteration function that does not deduplicate !

This revision now requires changes to proceed.Jul 1 2021, 8:27 PM
swh/model/tests/test_merkle.py
175

maybe you can rename this test case to test_iter_tree_with_deduplication, for clearer output wrt the newly added one

Build is green

Patch application report for D5951 (id=21421)

Rebasing onto cfb3073c27...

First, rewinding head to replay your work on top of it...
Applying: make deduplication optional when iterating over the merkle tree
Changes applied before test
commit c4432994755b57d9a87fd3eecdbcb612472be375
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jun 29 13:42:54 2021 +0100

    make deduplication optional when iterating over the merkle tree

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/363/ for more details.

This revision is now accepted and ready to land.Jul 2 2021, 10:16 AM

Build is green

Patch application report for D5951 (id=21432)

Rebasing onto cfb3073c27...

Current branch diff-target is up to date.
Changes applied before test
commit 153c6e84421b2186bb17a35abe866a4eac3c1359
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jun 29 13:42:54 2021 +0100

    make deduplication optional when iterating over the merkle tree

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/364/ for more details.