cassandra: Add support for non-ASCII origin 'URLs'.
ClosedPublic
Actions

Authored by vlorentz on Jun 25 2021, 5:27 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Maniphest Tasks

T3394: cassandra - origin url hashing encoding issue

Commits

rDSTOec2fac447816: cassandra: Add support for non-ASCII origin 'URLs'.

Summary

We agreed a while ago they are IRIs, and we have some of them in the
postgresql database already.

Closes T3394

Test Plan

New test for origins
test_add_arbitrary will check it for other object types thanks to D5931.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22275
Build 34669: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34668: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 25 2021, 5:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 25 2021, 5:27 PM

Build has FAILED

Patch application report for D5932 (id=21295)

Rebasing onto 47575a6932...

Current branch diff-target is up to date.

Changes applied before test

commit ec2fac4478166ea7a8bade2681e074130612dd2c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 17:26:53 2021 +0200

    cassandra: Add support for non-ASCII origin 'URLs'.
    
    We agreed a while ago they are IRIs, and we have some of them in the
    postgresql database already.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1344/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1344/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 25 2021, 5:35 PM

Harbormaster failed remote builds in B22275: Diff 21295!

(build failure happens on master too,, and will be fixed with the next swh-model release)

Build is green

Patch application report for D5932 (id=21295)

Rebasing onto 47575a6932...

Current branch diff-target is up to date.

Changes applied before test

commit ec2fac4478166ea7a8bade2681e074130612dd2c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 17:26:53 2021 +0200

    cassandra: Add support for non-ASCII origin 'URLs'.
    
    We agreed a while ago they are IRIs, and we have some of them in the
    postgresql database already.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1345/ for more details.

Harbormaster completed remote builds in B22275: Diff 21295.Jun 28 2021, 10:09 AM