Page MenuHomeSoftware Heritage
Differential D5901

Make the origin visit scheduling cooldown configurable
ClosedPublic
Actions

Authored by olasd on Jun 21 2021, 4:46 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSCHce8608d1f888: Make the origin visit scheduling cooldown configurable
Summary

Split off from D5809, now with tests

Test Plan

new tests added for non default values of the cooldown

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jun 21 2021, 4:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 21 2021, 4:46 PM
olasd mentioned this in D5809: Direct scheduling of origin visits in celery.Jun 21 2021, 4:48 PM
swh-public-ci added a comment.Jun 21 2021, 4:49 PM

Build is green

Patch application report for D5901 (id=21163)

Rebasing onto 9e1b4145fe...

Current branch diff-target is up to date.
Changes applied before test
commit 4027b3ef7b832036146525849faee78cfbc0091c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jun 21 16:34:21 2021 +0200

    Make the origin visit scheduling cooldown configurable

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/367/ for more details.

Harbormaster completed remote builds in B22150: Diff 21163.Jun 21 2021, 4:49 PM
olasd requested review of this revision.Jun 21 2021, 4:49 PM
ardumont added a subscriber: ardumont.Jun 21 2021, 5:04 PM
ardumont added inline comments.
swh/scheduler/tests/test_scheduler.py
773

?

ardumont accepted this revision.Jun 21 2021, 5:06 PM

lgtm, one test docstring sentence phrasing improvment inline.

This revision is now accepted and ready to land.Jun 21 2021, 5:06 PM
olasd updated this revision to Diff 21169.Jun 21 2021, 5:07 PM

Update backoff checking logic to vary the grab timestamp instead of the configured backoff

swh-public-ci added a comment.Jun 21 2021, 5:10 PM

Build is green

Patch application report for D5901 (id=21169)

Rebasing onto 9e1b4145fe...

Current branch diff-target is up to date.
Changes applied before test
commit 1bcfd5a0b1aedcbb4f3a2511b897e4d7e0b70fc9
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jun 21 16:34:21 2021 +0200

    Make the origin visit scheduling cooldown configurable

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/369/ for more details.

Harbormaster completed remote builds in B22156: Diff 21169.Jun 21 2021, 5:10 PM
olasd updated this revision to Diff 21179.Jun 21 2021, 5:36 PM

Only vary the backoff test timestamp by 1 second

olasd added a child revision: D5903: Add a (longer) specific cooldown for failed origin visits.Jun 21 2021, 5:37 PM
swh-public-ci added a comment.Jun 21 2021, 5:39 PM

Build is green

Patch application report for D5901 (id=21179)

Rebasing onto 9e1b4145fe...

Current branch diff-target is up to date.
Changes applied before test
commit 73121c76c21080e1ee2dba79532d9901860f4777
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jun 21 17:36:00 2021 +0200

    Make the origin visit scheduling cooldown configurable

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/370/ for more details.

Harbormaster completed remote builds in B22166: Diff 21179.Jun 21 2021, 5:39 PM
ardumont accepted this revision.Jun 21 2021, 5:42 PM
olasd updated this revision to Diff 21217.Jun 23 2021, 11:14 AM

rebase

swh-public-ci added a comment.Jun 23 2021, 11:17 AM

Build is green

Patch application report for D5901 (id=21217)

Rebasing onto 7f51f274ed...

Current branch diff-target is up to date.
Changes applied before test
commit ce8608d1f8887993ae6ddf56169cb4c117243461
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jun 21 17:36:00 2021 +0200

    Make the origin visit scheduling cooldown configurable

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/375/ for more details.

Harbormaster completed remote builds in B22204: Diff 21217.Jun 23 2021, 11:17 AM
Closed by commit rDSCHce8608d1f888: Make the origin visit scheduling cooldown configurable (authored by olasd). · Explain WhyJun 23 2021, 11:29 AM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDSCHce8608d1f888: Make the origin visit scheduling cooldown configurable.

Revision Contents
Changeset List

PathSize
swh/
scheduler/
31 lines
3 lines
tests/
87 lines

Diff 21221

View Options

swh/scheduler/backend.py

Loading...
View Options

swh/scheduler/interface.py

Loading...
View Options

swh/scheduler/tests/test_scheduler.py

Loading...
About · Developer information · Legal