Paths

Table of Contentst

Differential D5835

Add typing stubs dependencies for mypy>0.900
ClosedPublic
Actions

Authored by ardumont on Jun 9 2021, 12:30 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSCH9d2618db8faf: Add typing stubs dependencies for mypy>0.900

Summary

Fixes build [1]

Not necessarily for review, just to ensure jenkins is happy enough.

[1] https://jenkins.softwareheritage.org/view/swh-draft/job/DSCH/job/tests/1429/console

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 9 2021, 12:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 9 2021, 12:30 PM

Build has FAILED

Patch application report for D5835 (id=20870)

Rebasing onto 9f7ab8fcdc...

Current branch diff-target is up to date.

Changes applied before test

commit 264bfe0f38e3b66fe0925e680930e2ab4663a7b8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 9 12:29:38 2021 +0200

    Add typing stubs dependencies for mypy>0.900

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/355/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/355/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2021, 12:31 PM

Harbormaster failed remote builds in B21832: Diff 20870!

ardumont edited the summary of this revision. (Show Details)Jun 9 2021, 12:31 PM

Fix typo

Build is green

Patch application report for D5835 (id=20872)

Rebasing onto 9f7ab8fcdc...

Current branch diff-target is up to date.

Changes applied before test

commit a698b367505ef6a7a94197e769b6180ccdac08f7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 9 12:29:38 2021 +0200

    Add typing stubs dependencies for mypy>0.900
    
    This also explicits missing dependencies

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/356/ for more details.

Harbormaster completed remote builds in B21835: Diff 20872.Jun 9 2021, 12:36 PM

ardumont requested review of this revision.Jun 9 2021, 12:36 PM

anlambert requested changes to this revision.Jun 9 2021, 12:44 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

requirements.txt
10–16	package names are case insensitive on PyPI so I would go for lowercase only instead.
18–21	You should put those in `requirements-test.txt` instead as they are not required for execution.

This revision now requires changes to proceed.Jun 9 2021, 12:44 PM

anlambert added inline comments.Jun 9 2021, 12:46 PM

requirements.txt
17	you can drop that requirement why you are processing that file, it is already declared in `requirements-test.txt`
17	did not see it was commented but should be removed anyway

Adapt according to suggestions

Build is green

Patch application report for D5835 (id=20875)

Rebasing onto 9f7ab8fcdc...

Current branch diff-target is up to date.

Changes applied before test

commit 9d2618db8faf02dfa4539d9a8debe7efe84433f5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 9 12:29:38 2021 +0200

    Add typing stubs dependencies for mypy>0.900
    
    This also explicits missing dependencies

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/357/ for more details.

Harbormaster completed remote builds in B21838: Diff 20875.Jun 9 2021, 2:17 PM

anlambert accepted this revision.Jun 9 2021, 2:22 PM

anlambert added inline comments.