Page MenuHomeSoftware Heritage

backend: Allow lister exclusion from the grab_next_visit endpoint
AbandonedPublic

Authored by ardumont on May 31 2021, 3:19 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T3350: Deploy sourceforge lister in production
Summary

(No test yet as i'm trying to ensure i'm going the right way first)

Related to T3350

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21684
Build 33701: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 33700: arc lint + arc unit

Event Timeline

I'd suggest using a simpler "lister_id not in (select id from lister where name in %s)" where clause to avoid having to add a join to the query. I'd even go as far as suggesting using a list of lister uuids directly instead (which avoids having to pass a complex filter with name and instance_name to the scheduling function).

Build is green

Patch application report for D5802 (id=20723)

Rebasing onto 9f7ab8fcdc...

Current branch diff-target is up to date.
Changes applied before test
commit 1147d39ddde38409622b896129c698bda37cb977
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 31 15:05:58 2021 +0200

    backend: Allow lister exclusion from the grab_next_visit endpoint
    
    Related to T3350

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/349/ for more details.