Differential D5798

metadata: Fix UnboundLocalError in edge case
ClosedPublic
Actions

Authored by ardumont on May 28 2021, 3:04 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDXcf598baacb1e: metadata: Fix UnboundLocalError in edge case

Summary

This fixes occurrences of [1]

[1] https://sentry.softwareheritage.org/share/issue/4b92519efe2a4ddd9455f0d600a614b9/

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 28 2021, 3:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 28 2021, 3:04 PM

Build is green

Patch application report for D5798 (id=20714)

Rebasing onto 8fd4846af5...

Current branch diff-target is up to date.

Changes applied before test

commit ff0b60e84e404e9dc9bf93210d248f4a6f87b237
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 28 15:02:24 2021 +0200

    metadata: Fix UnboundLocalError in edge case
    
    This fixes occurrences of [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/4b92519efe2a4ddd9455f0d600a614b9/

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/178/ for more details.

Harbormaster completed remote builds in B21676: Diff 20714.May 28 2021, 3:26 PM

ardumont requested review of this revision.May 28 2021, 3:26 PM

oops

This revision is now accepted and ready to land.May 28 2021, 3:27 PM

Fix copyright header

Build is green

Patch application report for D5798 (id=20717)

Rebasing onto 8fd4846af5...

Current branch diff-target is up to date.

Changes applied before test

commit cf598baacb1efdfdf205c57a902be9f06cd6c523
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 28 15:02:24 2021 +0200

    metadata: Fix UnboundLocalError in edge case
    
    This fixes occurrences of [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/4b92519efe2a4ddd9455f0d600a614b9/

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/180/ for more details.

Harbormaster completed remote builds in B21679: Diff 20717.May 28 2021, 3:49 PM

Closed by commit rDCIDXcf598baacb1e: metadata: Fix UnboundLocalError in edge case (authored by ardumont). · Explain WhyMay 28 2021, 3:55 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXcf598baacb1e: metadata: Fix UnboundLocalError in edge case.