Page MenuHomeSoftware Heritage

pytest_plugin: Explicitly set hostname in broker_url for celery TestApp
ClosedPublic

Authored by anlambert on May 25 2021, 12:26 PM.

Details

Summary

Since the release of kombu 5.1.0, a warning is now issued when a hostname
is not set in the broker_url config value of a celery app.

That change makes the test_celery_monitor_ping test fails due to that
new unexpected warning.

So explicitly add localhost hostname in the broker_url value of the
celery TestApp config.

Related Github commit and issue:

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build was aborted

Patch application report for D5776 (id=20646)

Rebasing onto fe9d94905a...

Current branch diff-target is up to date.
Changes applied before test
commit f074ff40336db89ecb4273b2d0150f70b01c1fd9
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 12:15:04 2021 +0200

    pytest_plugin: Explicitly set broker_url config for celery TestApp
    
    Since the release of kombu 5.1.0, a warning is now issued when the
    broker URL is not explicitly set in the celery config.
    
    That change makes the test_celery_monitor_ping test fails due to that
    new unexpected warning.
    
    So ensure to explicitly set the broker_url value it in the celery
    TestApp config.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/344/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/344/console

Build was aborted

Patch application report for D5776 (id=20646)

Rebasing onto fe9d94905a...

Current branch diff-target is up to date.
Changes applied before test
commit f074ff40336db89ecb4273b2d0150f70b01c1fd9
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 12:15:04 2021 +0200

    pytest_plugin: Explicitly set broker_url config for celery TestApp
    
    Since the release of kombu 5.1.0, a warning is now issued when the
    broker URL is not explicitly set in the celery config.
    
    That change makes the test_celery_monitor_ping test fails due to that
    new unexpected warning.
    
    So ensure to explicitly set the broker_url value it in the celery
    TestApp config.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/345/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/345/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 1:04 PM
Harbormaster failed remote builds in B21610: Diff 20646!

Tests are hanging on Jenkins, comment changes temporarily to check if it is related
(does not hang with local tox)

Build has FAILED

Patch application report for D5776 (id=20648)

Rebasing onto fe9d94905a...

Current branch diff-target is up to date.
Changes applied before test
commit a8a782e73b5853de9f2a1f32c22c9a455f0320ad
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 12:15:04 2021 +0200

    pytest_plugin: Explicitly set broker_url config for celery TestApp
    
    Since the release of kombu 5.1.0, a warning is now issued when the
    broker URL is not explicitly set in the celery config.
    
    That change makes the test_celery_monitor_ping test fails due to that
    new unexpected warning.
    
    So ensure to explicitly set the broker_url value it in the celery
    TestApp config.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/346/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/346/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2021, 1:37 PM
Harbormaster failed remote builds in B21612: Diff 20648!

Tests did not hang with the change commented, uncomment it back for more build tests

Fix tests hang on Jenkins, broker must be a memory one, not a RabbitMQ one.

anlambert retitled this revision from pytest_plugin: Explicitly set broker_url config for celery TestApp to pytest_plugin: Explicitly set hostname in broker_url for celery TestApp.May 25 2021, 1:49 PM
anlambert edited the summary of this revision. (Show Details)
anlambert edited the summary of this revision. (Show Details)

Build was aborted

Patch application report for D5776 (id=20649)

Rebasing onto fe9d94905a...

Current branch diff-target is up to date.
Changes applied before test
commit 926b08b5707d83181b89323ac08a5719016a4c6a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 12:15:04 2021 +0200

    pytest_plugin: Explicitly set broker_url config for celery TestApp
    
    Since the release of kombu 5.1.0, a warning is now issued when the
    broker URL is not explicitly set in the celery config.
    
    That change makes the test_celery_monitor_ping test fails due to that
    new unexpected warning.
    
    So ensure to explicitly set the broker_url value it in the celery
    TestApp config.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/347/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/347/console

Build is green

Patch application report for D5776 (id=20650)

Rebasing onto fe9d94905a...

Current branch diff-target is up to date.
Changes applied before test
commit 9f7ab8fcdc3586daf2bd13400394c697216dce00
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 25 12:15:04 2021 +0200

    pytest_plugin: Explicitly set hostname in broker_url for celery TestApp
    
    Since the release of kombu 5.1.0, a warning is now issued when a hostname
    is not set in the broker_url config value of a celery app.
    
    That change makes the test_celery_monitor_ping test fails due to that
    new unexpected warning.
    
    So explicitly add localhost hostname in the broker_url value of the
    celery TestApp config.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/348/ for more details.

This revision is now accepted and ready to land.May 25 2021, 2:12 PM