azure: Use container URLs instead of ContainerClient instances as attributes
ClosedPublic
Actions

Authored by vlorentz on May 17 2021, 1:33 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDOBJS5a3111c6d02c: azure: Use container URLs instead of ContainerClient instances as attributes

Summary

A future commit will start using aio.ContainerClient instances, which must
be created on the fly from these URLs.

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 17 2021, 1:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 17 2021, 1:33 PM

Build is green

Patch application report for D5742 (id=20533)

Rebasing onto 326fcef47b...

Current branch diff-target is up to date.

Changes applied before test

commit 5a3111c6d02c0d6fcdf6c295ff6b12aff9fd4fb7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 17 13:32:07 2021 +0200

    azure: Use container URLs instead of ContainerClient instances as attributes
    
    A future commit will start using aio.ContainerClient instances, which must
    be created on the fly from these URLs.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/22/ for more details.

Harbormaster completed remote builds in B21513: Diff 20533.May 17 2021, 1:35 PM

vlorentz requested review of this revision.May 17 2021, 1:35 PM

vlorentz added a child revision: D5743: azure: Specialize get_batch() to fetch objects concurrently.May 17 2021, 1:40 PM

olasd accepted this revision.May 17 2021, 5:31 PM

olasd added a subscriber: olasd.

olasd added inline comments.

swh/objstorage/tests/test_objstorage_azure.py
71–97	the `blobs` defaultdict could probably be a class attribute (and `self.blobs` turned into a proxy for said class attribute) but it doesn't matter much